Skip to content

Conversation

@regzo2
Copy link
Contributor

@regzo2 regzo2 commented Aug 21, 2023

This PR includes several additions:

FilterTable component

  • Let's you organize, search, and configure tables to be easily readable!
  • Updated Unified Expressions references to use it.
  • Usage:
<FilterTable
  title={'Standard Comparison Table'} // (optional) title attached to top of the table.
  headers={['Unified', 'Unified Blended', 'SRanipal']} // headers (string).
  omitHeaders={['Unified', 'SRanipal']} // (optional) (string and match header) hides button and always shows column
  disabledHeaders={['Unified Blended']} // (optional) these will be deactivated by default, but can be toggled.
  rows={[
    ['ExampleUnified', 'ExampleBlended', 'ExampleSRanipal'], // Rows, cells line up to header. Can be anything.
    [<>ExampleJSXElement</>, <ExampleReactComponent/>, <>Cool<br/>Beans</>],
    // add more rows.
  ]}
 />

finaltable

finaltableunified

Hardware: Comparison Page

This page includes a bunch of information that might be helpful for users to quickly compare across different software, hardware, or else for face tracking capabilities.

image

image

Expressions Comparison Page

This page includes a bunch of information that might be helpful for users to quickly compare across different popular face tracking standards, and even provides some insights as to how Unified Expressions allows all of them to work!

image

Individual Comparison Pages

There several sections for each standard that directly compares them to Unified Expressions, and how best to translate the specific standard to work best for UE compatible avatars or setups.

image

@kusomaigo
Copy link
Contributor

I think the hardware tracking compatibilities page has some confusing mistakes, and I finally got around to trying to correct them when I noticed maybe I don't understand all the rows: some entries have X for (Upper face) Expressability but a value for Quality, some have ~ for Expressability and still a value for Quality, etc. Take a look at Project Babble column, Vive Facial Tracker column, etc. Also, for some reason the right side table border ends up short sometimes (differs depending on rightmost column)

image

I think the avatar side is pretty good, except I'm not sure if, for ARKit specifically which has a few "left/right combined" shapes, to have the comparison table add an extra row just for that. I think it would be better to just have, for example:

UE ARKit
BrowInnerUpRight BrowInnerUp*
BrowInnerUpLeft BrowInnerUp*

Sorry for being super late with this review btw Azmidi, in general this PR is really neat and needed.

@regzo2
Copy link
Contributor Author

regzo2 commented Sep 7, 2023

I think the hardware tracking compatibilities page has some confusing mistakes, and I finally got around to trying to correct them when I noticed maybe I don't understand all the rows: some entries have X for (Upper face) Expressability but a value for Quality, some have ~ for Expressability and still a value for Quality, etc. Take a look at Project Babble column, Vive Facial Tracker column, etc. Also, for some reason the right side table border ends up short sometimes (differs depending on rightmost column)

image

Looks to be a mistake on the formatting of the table. I will double check over this and make sure everything is correct.

I think the avatar side is pretty good, except I'm not sure if, for ARKit specifically which has a few "left/right combined" shapes, to have the comparison table add an extra row just for that. I think it would be better to just have, for example:

UE ARKit
BrowInnerUpRight BrowInnerUp*
BrowInnerUpLeft BrowInnerUp*

Yeah that makes sense, I had all shapes more-so lined up to where they're supposed to correlate to in Unified Expressions, and a lot of ARKit lined up with a lot of the Blended shapes like with Movement. If this change makes it more readable in the general table then I can make this change.

@kusomaigo
Copy link
Contributor

Yeah that makes sense, I had all shapes more-so lined up to where they're supposed to correlate to in Unified Expressions, and a lot of ARKit lined up with a lot of the Blended shapes like with Movement. If this change makes it more readable in the general table then I can make this change.

I think alternatively, you can make the UE side more obvious the correspondence is with a Blended shape, maybe bolding the UE name or adding a highlight or something

@regzo2
Copy link
Contributor Author

regzo2 commented Sep 25, 2023

Fixed everything addressed, Blended shapes merged into a single table on each standard page and bolded to help distinguish them. Corrected all the information on the HW comparison pages.

Copy link
Contributor

@kusomaigo kusomaigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The squeeze comparison in the avatars/compatibility page I think can be done better somehow, but as it is now is already very useful and we can deal with that later.

@kusomaigo kusomaigo merged commit 6bfa1e7 into master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants