refactor(compaction): trim generic event cleanup drift - #274
Merged
Conversation
- restore inline compaction-ended publication shape after the error guard - keep documented Swarm Default compaction fallback coverage unchanged - verify with compaction test and opencode typecheck
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A - refactor-only cleanup.
Type of change
What does this PR do?
Restores the compaction-ended event publication to the existing inline shape after the processor error guard and removes the redundant failure-event assertion added around it. The documented Swarm Default compaction fallback behavior and tests remain unchanged.
How did you verify your code works?
npx --yes bun@1.3.13 test --timeout 30000 test/session/compaction.test.tsfrompackages/opencodenpx --yes bun@1.3.13 run typecheckfrompackages/opencodebun turbo typecheckScreenshots / recordings
N/A - no UI change.
Checklist