refactor(core): align filesystem containment helper - #277
Merged
Conversation
- use upstream separator-aware contains predicate shape - cover boundary path containment cases
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Route overlap checks through the separator-aware containment helper in both core and opencode utilities. Cover child names beginning with dot-dot plus sibling and parent boundary cases.
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f10678ec9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- compare resolved parent boundaries for contains checks - cover Windows root-relative sibling collisions in core and opencode tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A - upstream-alignment cleanup for filesystem containment. Review found and fixed a Windows sibling-boundary bug in the helper.
Type of change
What does this PR do?
Aligns the fork filesystem containment helpers around resolved path-boundary checks instead of broad string prefix checks.
This covers
AppFileSystem.contains,Filesystem.contains, and overlap checks so parent/sibling escapes are rejected while valid child names beginning with two dots, such as..config, still stay inside the parent. The latest update also rejects Windows root-relative sibling prefix collisions such as/projectversus/project-other/file.How did you verify your code works?
cd packages/core && bun test test/filesystem/filesystem.test.tscd packages/opencode && bun test --timeout 30000 test/file/path-traversal.test.tscd packages/core && bun run typecheckcd packages/opencode && bun run typecheckgit diff --checkpath.win32simulation reproduced the old/projectversus/project-other/filefalse positive and confirmed the new boundary predicate rejects it while preserving/project/..configchildren.bun turbo typecheckScreenshots / recordings
N/A - no UI changes.
Checklist