fix(opencode): keep scanning agency entry fallbacks - #290
Merged
Conversation
- continue checking configured entry files after a project entry read error - preserve the original read error when no valid fallback is found - cover multi-entry downstream profile detection
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #289
Type of change
What does this PR do?
Keeps Agency Swarm project detection scanning configured fallback entry files after an entry-file read error.
A downstream profile can list more than one entry file, such as
main.pybeforeagency.py. If the first existing entry cannot be read, the launcher should still detect a later valid entry. If no valid fallback exists, it still surfaces the original read error.How did you verify your code works?
bun test test/agency-swarm/npx.test.ts -t "detectAgencyProject keeps checking configured entry files after read errors"bun test test/agency-swarm/npx.test.ts -t "prepareNpxLaunch offers recovery when agency.py cannot be read"bun typecheckScreenshots / recordings
Not a UI change.
Checklist