fix(ci): timeout Windows unit tests - #299
Merged
Merged
Conversation
- Split the unit test step so Windows has a bounded runtime. - Keep the Linux unit path unchanged. Fixes #298
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Collaborator
Author
|
@codex review |
nicko-ai
changed the title
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #298
Type of change
What does this PR do?
Adds a timeout to the Windows unit-test step so a hung
bun turbo test:cirun fails instead of blocking PR and release readiness indefinitely.The Linux unit step keeps the existing command. The Windows step runs the same command with the same environment and a 35-minute timeout.
How did you verify your code works?
.github/workflows/test.ymlas YAML and checked that the unit job now has separate Linux and Windows unit-test steps.git diff --check.d3c68a3bca0fe8523dbf79a1235b953e955e68e7; it found no actionable regression in the workflow split.Screenshots / recordings
Not applicable. This changes a GitHub Actions workflow only.
Checklist