test(opencode): use sync telemetry runner process - #321
Merged
Conversation
Fixes #298 Root cause: Windows unit CI completed tests successfully but the Bun test process stayed alive after the async telemetry runner subprocess path, timing out the step after success. Use spawnSync for the generated telemetry builder and runner helpers so child stdout/stderr handles are closed before assertions continue. Verification: bun test --timeout 30000 test/telemetry/telemetry.test.ts test/telemetry/command.test.ts; bun typecheck; git diff --check.
Collaborator
Author
|
@codex review |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #298
Type of change
What does this PR do?
Makes the compiled telemetry test harness use synchronous child processes for its generated builder and runner helpers.
The release-candidate Windows unit job completed all tests with zero failures, but the Bun test process stayed alive until the CI step timeout killed it. This removes the async child-process stream lifetime from the parent telemetry tests while keeping the same assertions.
How did you verify your code works?
bun test --timeout 30000 test/telemetry/telemetry.test.ts test/telemetry/command.test.tsbun typecheckbun turbo typecheckthrough the pre-push hookgit diff --checkWindows CI is the required proof that the post-success process exits cleanly.
Screenshots / recordings
Not applicable. This fixes test-harness process cleanup.
Checklist