Skip to content

Repeating shifts of a visual block created by upward movement does not work as expected #2521

Description

@scottopell

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

What happened:
I did a visual selection of a block upwards (eg Vkk>) and it indented the above two lines.
When I repeated this action via ., it went up two lines from the cursor and indented them, which is incorrect.
vscodevim_up_indent

What did you expect to happen:
I expected the block to re-indent the same lines I previously had selected.

Here is vim 8 doing the same thing:
vim_up_indent

How to reproduce it (as minimally and precisely as possible):
Vkk>.

Environment:

  • Extension (VsCodeVim) version: 0.11.3 (can replicate on master)
  • VSCode version: 1.21.1
  • OS version: MacOS 10.12.6

I added some failing tests to demonstrate this on my branch:
https://github.com/scottopell/Vim/tree/block-indent-repetition

I'm open to contributing a fix back to this, do you have any tips on where to get started? I'm not sure if this is a bug with the the way actions are repeated, or visual block, etc

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions