Skip to content

Remove duplicate target_summary route definition - #3382

Merged
adamtheturtle merged 1 commit into
mainfrom
adamtheturtle/vws-python-mock-issue-3372
Aug 9, 2026
Merged

Remove duplicate target_summary route definition#3382
adamtheturtle merged 1 commit into
mainfrom
adamtheturtle/vws-python-mock-issue-3372

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

validate_keys defined target_summary twice, identically, so the second assignment overwrote the first with the same value and only one ended up in the routes tuple. This deletes the second definition; behaviour is unchanged.

I also checked whether ruff or pylint has a rule for redundant local reassignment that we currently have disabled — neither does. Ruff's nearest rules (F811, PLR1704, PLW2901, the A0xx shadowing family) do not cover a plain local being reassigned before its value is read, and none of them are in our ignore list.

Closes #3372

🤖 Generated with Claude Code

Closes #3372

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

target_summary is defined twice in validate_keys

1 participant