mbpt: spell OpClass enumerators in CamelCase - #587
Merged
Conversation
Rename ex/deex/gen to Ex/Deex/Gen, matching the CamelCase convention used by the other non-QNS enums (CSV, Convention, SpinConvention, Normalization, BiorthogonalizationMethod, ...). The quantum-number bitmask enums in space_qns.hpp -- Spin, LCAOQNS, TensorFactorizationQNS, BatchingQNS -- deliberately keep their lower-case enumerators, since those spell physics notation (Spin::alpha, TensorFactorizationQNS::df, ...). Enumerator order is unchanged, so the underlying values are stable. This does break downstream code that names the enumerators; no deprecated aliases are provided.
Member
Author
|
CI failure is due to an ongoing Github Actions issue |
evaleev
force-pushed
the
ajay/fix/opclass-case
branch
from
August 6, 2026 17:33
f188451 to
764052a
Compare
evaleev
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just following the convention in other places for consistency.