Skip to content

Fix inconsistencies in rank-local SVD wrapper #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2021
Merged

Fix inconsistencies in rank-local SVD wrapper #263

merged 4 commits into from
Apr 2, 2021

Conversation

@wavefunction91
Copy link

@wavefunction91 wavefunction91 commented Mar 25, 2021 •
edited
Loading

Addresses #262

This PR implements the following changes:

  1. The rank-local SVD wrapper now does the "right" thing viz reallocating U/VT to the right dimensions based on the desired outputs.
  2. Changes the default behaviour to be "SomeVec" as opposed to "AllVec" to coincide with ScaLAPACK APIs
  3. Adds flexibility in the rank-local SVD wrapper to allow for all allowable "Job" types for XGESVD in LAPACK

@evaleev evaleev requested a review from asadchev April 2, 2021 15:48
@evaleev
Copy link
Member

evaleev commented Apr 2, 2021

@asadchev please have a look

@evaleev evaleev merged commit 96783eb into ValeevGroup:master Apr 2, 2021
@wavefunction91 wavefunction91 mentioned this pull request Apr 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evaleev evaleev evaleev approved these changes

@asadchev asadchev Awaiting requested review from asadchev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wavefunction91 @evaleev @asadchev