Add QR Implementations #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 14, 2021 12:11
evaleev
approved these changes
Oct 20, 2021
Member
|
@wavefunction91 thanks! which solvers need to be reviewed for R/C issues? |
Author
|
@evaleev I'm just bad at reading code, nvm, everything is calling lapackpp,
we should be good-to-go. I'll patch with the correct sequence for complex Q
formation.
…On Wed, Oct 20, 2021 at 12:15 PM Eduard Valeyev ***@***.***> wrote:
Merged #316 <#316> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#316 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABPLZPJBWGNC3CXJW2NHDDTUH4INJANCNFSM5GCKGJNA>
.
|
Member
|
@wavefunction91 yeah I was worried we missed |
Closed
Author
|
@evaleev NVM again, I forgot what I was looking at previously e.g. https://github.com/ValeevGroup/tiledarray/blob/master/src/TiledArray/math/linalg/rank-local.cpp#L124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XGEQRF) + explicit Q construction from elementary reflectors (XORGQR)scalapackpp