Asadchev/feature/einsum ta dot #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@asadchev seems to be WIP? (the einsum_dot test is disabled) |
Contributor
Author
|
It's failing in parallel with scalapack enabled, so i just gave up on it
…On Mon, Sep 26, 2022, 3:21 PM Eduard Valeyev ***@***.***> wrote:
@asadchev <https://github.com/asadchev> seems to be WIP? (the einsum_dot
test is disabled)
—
Reply to this email directly, view it on GitHub
<#369 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH62KF4TIH6ZVN2XZI6BYLWAHSSPANCNFSM6AAAAAAQTFILIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
evaleev
reviewed
Nov 14, 2022
tests/einsum.cpp
Outdated
| ); | ||
| } | ||
|
|
||
| BOOST_AUTO_TEST_CASE(einsum_tiledarray_dot) { |
Member
There was a problem hiding this comment.
@asadchev I uncommented this ... should I comment it out?
Contributor
Author
|
it fails parallel test that's why i commented it out
…On Mon, Nov 14, 2022, 2:12 PM Eduard Valeyev ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/einsum.cpp
<#369 (comment)>
:
> @@ -723,4 +723,19 @@ BOOST_AUTO_TEST_CASE(einsum_tiledarray_replicated) {
);
}
+ BOOST_AUTO_TEST_CASE(einsum_tiledarray_dot) {
@asadchev <https://github.com/asadchev> I uncommented this ... should I
comment it out?
—
Reply to this email directly, view it on GitHub
<#369 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABH62KDZM4WY2XENGYPKH3DWIKTMJANCNFSM6AAAAAAQTFILIU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
… broadcast (from all_reduce) tasks getting stuck in per-thread task queue (if using pthread-based MADNESS task backend) of the main thread, if the main thread gets subsequently stuck in e.g. blocking MPI calls these tasks will be never executed and other ranks cannot make progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.