Skip to content

ExternalProject_Add avoids touching install directory at configure time #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024
Merged

ExternalProject_Add avoids touching install directory at configure time #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce2c33
fetching eigen3 via ExternalProject_Add's needs to specify STAMP_DIR …
evaleev Apr 2, 2024
5e22878
to avoid premature creation of install directory ExternalProject_add …
evaleev Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions external/eigen.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,10 @@ else()
message("** Will build Eigen from ${EIGEN3_URL}")

ExternalProject_Add(eigen3
PREFIX ${CMAKE_INSTALL_PREFIX}
#--Download step--------------
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/eigen3-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/eigen3-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
DOWNLOAD_DIR ${EXTERNAL_SOURCE_DIR}
URL ${EIGEN3_URL}
URL_HASH ${EIGEN3_URL_HASH}
Expand Down
2 changes: 1 addition & 1 deletion external/librett.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ else()
message(STATUS "custom target librett is expected to build these byproducts: ${LIBRETT_BUILD_BYPRODUCTS}")

ExternalProject_Add(librett
PREFIX ${CMAKE_INSTALL_PREFIX}
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/librett-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/librett-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
Expand Down
2 changes: 1 addition & 1 deletion external/umpire.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ else()
message(STATUS "custom target Umpire is expected to build these byproducts: ${UMPIRE_BUILD_BYPRODUCTS}")

ExternalProject_Add(Umpire
PREFIX ${CMAKE_INSTALL_PREFIX}
PREFIX ${FETCHCONTENT_BASE_DIR}
STAMP_DIR ${FETCHCONTENT_BASE_DIR}/umpire-ep-artifacts
TMP_DIR ${FETCHCONTENT_BASE_DIR}/umpire-ep-artifacts # needed in case CMAKE_INSTALL_PREFIX is not writable
#--Download step--------------
Expand Down