-
Notifications
You must be signed in to change notification settings - Fork 58
can change DistArray's trange (retile + more) #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iledArray/meta.h deprecated in favor of TiledArray/util/invoke.h
…ge can stay same or change, up or down)
…ent-level reranging (retiling, etc.)
…t complex "constructors" in ArrayImpl
…ling by default (thanks, @calewis )
80fb70e to
c275ec5
Compare
… + test negative lobound if using signed 1-index type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block expressions are the efficient way to use rectilinear subset of DistArray's tiles in expressions. Keeping tiling unchanged is often a severe constraint: often we want to retile the data, in combination with growing/shrinking/changing the element range.
TA::retileprovides a limited subset of such functionality (and is inefficient). This PR provides the full nearly-optimal implementation that allows to create a new DistArray with a given TiledRange and the data of an existingDistArray(new elements are initialized to a constant).