Skip to content

Move heartbeat timer into session state#133

Merged
davidsteiner merged 4 commits into
mainfrom
109-avoid-heartbeats-when-there-is-no-established-session
Jul 31, 2025
Merged

Move heartbeat timer into session state#133
davidsteiner merged 4 commits into
mainfrom
109-avoid-heartbeats-when-there-is-no-established-session

Conversation

@davidsteiner

Copy link
Copy Markdown
Member

This ensures that heartbeats only tick when we're in a valid state for heartbeating.

@codecov

codecov Bot commented Jul 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.42%. Comparing base (a3b1d61) to head (40a5f19).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/hotfix/src/session.rs 57.14% 3 Missing ⚠️
crates/hotfix/src/session/state.rs 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   62.27%   62.42%   +0.15%     
==========================================
  Files          66       66              
  Lines        2749     2760      +11     
==========================================
+ Hits         1712     1723      +11     
  Misses       1037     1037              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner requested a review from DGPardo July 31, 2025 11:30
DGPardo
DGPardo previously approved these changes Jul 31, 2025
Comment thread crates/hotfix/src/session/state.rs
Comment thread crates/hotfix/tests/session_tests.rs Outdated
@davidsteiner davidsteiner merged commit 6a6f7e3 into main Jul 31, 2025
4 checks passed
@davidsteiner davidsteiner deleted the 109-avoid-heartbeats-when-there-is-no-established-session branch July 31, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants