Skip to content

Fix unhandled exception for invalid numeric SteamIDs #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossengeorgiev merged 2 commits into from
Apr 15, 2020
Merged

Fix unhandled exception for invalid numeric SteamIDs #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7672d73
Fix unhandled exception for invalid numeric SteamIDs
int3l Apr 11, 2020
5cb5953
Test for too large integer or numeric string SteamIDs
int3l Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions steam/steamid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,9 @@ def make_steam64(id=0, *args, **kwargs):
# 64 bit
elif value < 2**64:
return value
# invalid account id
else:
accountid = 0

# textual input e.g. [g:1:4]
else:
Expand Down
6 changes: 6 additions & 0 deletions tests/test_steamid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,12 @@ def test_arg_text_invalid(self):
self.compare(SteamID("invalid_format"),
[0, EType.Invalid, EUniverse.Invalid, 0])

def test_arg_too_large_invalid(self):
self.compare(SteamID(111111111111111111111111111111111111111),
[0, EType.Invalid, EUniverse.Invalid, 0])
self.compare(SteamID("1111111111111111111111111111111111111"),
[0, EType.Invalid, EUniverse.Invalid, 0])

######################################################
# KWARGS
######################################################
Expand Down