Backporting c3ab23a10771bbe06300e5374efa809789c65455 breaks sound in kernel 6.7.4 ASoC: amd: Add new dmi entries for acp5x platform

[hungrymonkey]

Your system information

• Steam client version: n/a
• SteamOS version: Not Steam OS. Latest stable kernel

Please describe your issue in as much detail as possible:

I want to give a heads up. Back porting c3ab23a10771bbe06300e5374efa809789c65455 commit above breaks audio. The development rc kernel still works.

Steps for reproducing this issue:

1. Install a tradition distro with kernel 6.7.4 kernel release
2. Boot and audio is broken

https://lkml.org/lkml/2024/2/12/728

[    8.755614] cs35l41 spi-VLV1776:00: supply VA not found, using dummy regulator
[    8.760506] cs35l41 spi-VLV1776:00: supply VP not found, using dummy regulator
[    8.777148] cs35l41 spi-VLV1776:00: Cirrus Logic CS35L41 (35a40), Revision: B2
[    8.777471] cs35l41 spi-VLV1776:01: supply VA not found, using dummy regulator
[    8.777532] cs35l41 spi-VLV1776:01: supply VP not found, using dummy regulator
[    8.777709] cs35l41 spi-VLV1776:01: Reset line busy, assuming shared reset
[    8.788465] cs35l41 spi-VLV1776:01: Cirrus Logic CS35L41 (35a40), Revision: B2
[    8.877280] snd_hda_intel 0000:04:00.1: enabling device (0000 -> 0002)
[    8.877595] snd_hda_intel 0000:04:00.1: Handle vga_switcheroo audio client
[    8.889913] snd_acp_pci 0000:04:00.5: enabling device (0000 -> 0002)
[    8.890063] snd_acp_pci 0000:04:00.5: Unsupported device revision:0x50
[    8.890129] snd_acp_pci: probe of 0000:04:00.5 failed with error -22
[    8.906136] snd_hda_intel 0000:04:00.1: bound 0000:04:00.0 (ops amdgpu_dm_audio_component_bind_ops [amdgpu])

Affected dmesg
dmesg-6.7.4-1-default.txt

[hungrymonkey]

LCD deck

Handle 0x0000, DMI type 0, 26 bytes
BIOS Information
	Vendor: Valve
	Version: F7A0120
	Release Date: 12/01/2023
	Address: 0xE0000
	Runtime Size: 128 kB
	ROM Size: 16 MB
	Characteristics:
		PCI is supported
		BIOS is upgradeable
		BIOS shadowing is allowed
		Boot from CD is supported
		Selectable boot is supported
		EDD is supported
		Japanese floppy for NEC 9800 1.2 MB is supported (int 13h)
		Japanese floppy for Toshiba 1.2 MB is supported (int 13h)
		5.25"/360 kB floppy services are supported (int 13h)
		5.25"/1.2 MB floppy services are supported (int 13h)
		3.5"/720 kB floppy services are supported (int 13h)
		3.5"/2.88 MB floppy services are supported (int 13h)
		8042 keyboard services are supported (int 9h)
		CGA/mono video services are supported (int 10h)
		ACPI is supported
		USB legacy is supported
		BIOS boot specification is supported
		Targeted content distribution is supported
		UEFI is supported
	BIOS Revision: 1.20
	Firmware Revision: 1.16

[RodoMa92]

That's interesting. I'm running 6.7.4 on a LCD Deck and my audio works just fine here. I'll check if my maintainers reverted that change already, otherwise it might be an oddball conditional bug on that change.

[RodoMa92]

This specific patch has been cherry-picked from Valve's sources, so it might be the reason that I haven't seen the same issue on my running kernel. Not sure if that is already merged upstream or not.

[hungrymonkey]

This specific patch has been cherry-picked from Valve's sources, so it might be the reason that I haven't seen the same issue on my running kernel. Not sure if that is already merged upstream or not.

I do not see those patches are in Linus's branch. The sound works in 6.8.rc3.

[hungrymonkey]

I guess let AMD, Valve and upstream maintainers sort this issue out I guess....

[RodoMa92]

I guess let AMD, Valve and upstream maintainers sort this issue out I guess....

No, reporting this here is good, but I'm not sure how to actually reach them, besides maybe responding directly to the committer email to warn them that they introduced a regression.

I hardly see any developer around here, sadly.

[gregkh]

We're around, just quiet :)

I've queued the revert up for the next round of stable kernel updates upstream for kernel.org, thanks for reporting this.

[RodoMa92]

We're around, just quiet :)

I've queued the revert up for the next round of stable kernel updates upstream for kernel.org, thanks for reporting this.

Oh, I was referring at Valve devs, I know how to contact kernel developers on mainline, they are usually on email all the time

Thanks for letting that user aware though :)

[hungrymonkey]

We're around, just quiet :)

I've queued the revert up for the next round of stable kernel updates upstream for kernel.org, thanks for reporting this.

Thanks Greg

@RodoMa92

I wonder whether the kernel config would matter. Do you want to share your configs?

config-6.7.4-1-default.txt

config-6.8.0-rc4-1.g9b23bf2-default.txt

$diff config-6.7.4-1-default.txt config-6.8.0-rc4-1.g9b23bf2-default.txt

489a490,492
> 
> 
> 
575a579
> CONFIG_ACPI_THERMAL_LIB=y
627d630
< CONFIG_AIRO=m
650a654
> CONFIG_AMD_WBRF=y
682a687
> CONFIG_ARCH_HAS_CPU_PASID=y
697a703
> CONFIG_ARCH_HAS_HW_PTE_YOUNG=y
784c790
< CONFIG_AS_HAS_NON_CONST_LEB128=y
---
> CONFIG_AS_HAS_NON_CONST_ULEB128=y
856d861
< CONFIG_ATMEL=m
941a947
> CONFIG_BACKLIGHT_MP3309C=m
981a988
> CONFIG_BCACHEFS_SIX_OPTIMISTIC_SPIN=y
1058a1066
> CONFIG_BLK_DEV_WRITE_MOUNTED=y
1086a1095,1097
> CONFIG_BMI323_I2C=m
> CONFIG_BMI323=m
> CONFIG_BMI323_SPI=m
1106,1107d1116
< CONFIG_BPFILTER_UMH=m
< CONFIG_BPFILTER=y
1316a1326
> CONFIG_CC_NO_STRINGOP_OVERFLOW=y
1318c1328
< CONFIG_CC_VERSION_TEXT="gcc (SUSE Linux) 13.2.1 20240125 [revision fc7d87e0ffadca49bec29b2107c1efd0da6b6ded]"
---
> CONFIG_CC_VERSION_TEXT="gcc (SUSE Linux) 13.2.1 20240206 [revision 67ac78caf31f7cb3202177e6428a46d829b70f23]"
1578d1587
< CONFIG_CRYPTO_CFB=m
1605a1615
> CONFIG_CRYPTO_DEV_IAA_CRYPTO=m
1610a1621
> CONFIG_CRYPTO_DEV_QAT_420XX=m
1690d1700
< CONFIG_CRYPTO_OFB=m
1897a1908
> CONFIG_DP83TG720_PHY=m
1991a2003,2008
> CONFIG_DRM_XE_DISPLAY=y
> CONFIG_DRM_XE_ENABLE_SCHEDTIMEOUT_LIMIT=y
> CONFIG_DRM_XE_FORCE_PROBE=""
> CONFIG_DRM_XE_JOB_TIMEOUT_MAX=10000
> CONFIG_DRM_XE_JOB_TIMEOUT_MIN=1
> CONFIG_DRM_XE=m
1993a2011,2015
> CONFIG_DRM_XE_PREEMPT_TIMEOUT=640000
> CONFIG_DRM_XE_PREEMPT_TIMEOUT_MAX=10000000
> CONFIG_DRM_XE_PREEMPT_TIMEOUT_MIN=1
> CONFIG_DRM_XE_TIMESLICE_MAX=10000000
> CONFIG_DRM_XE_TIMESLICE_MIN=1
2188a2211
> CONFIG_DWC_PCIE_PMU=m
2361d2383
< CONFIG_FB_SYS_FOPS=y
2362a2385
> CONFIG_FB_SYSMEM_FOPS=y
2417a2441
> CONFIG_FRAMER=m
2420d2443
< CONFIG_FSCACHE=m
2421a2445
> CONFIG_FSCACHE=y
2430a2455
> CONFIG_FS_STACK=y
2483a2509
> CONFIG_GCC_NO_STRINGOP_OVERFLOW=y
2494a2521
> CONFIG_GENERIC_CPU_DEVICES=y
2709d2735
< CONFIG_HAVE_KVM_EVENTFD=y
2712d2737
< CONFIG_HAVE_KVM_IRQFD=y
2772,2774d2796
< CONFIG_HERMES_CACHE_FW_ON_INIT=y
< CONFIG_HERMES=m
< CONFIG_HERMES_PRISM=y
2837a2860
> CONFIG_HID_MCP2200=m
2923,2927d2945
< CONFIG_HOSTAP_FIRMWARE_NVRAM=y
< CONFIG_HOSTAP_FIRMWARE=y
< CONFIG_HOSTAP=m
< CONFIG_HOSTAP_PCI=m
< CONFIG_HOSTAP_PLX=m
3078a3097
> CONFIG_ICE_HWMON=y
3306a3326,3327
> CONFIG_INTEL_MEI_VSC_HW=m
> CONFIG_INTEL_MEI_VSC=m
3375a3397
> CONFIG_IOMMU_MM_DATA=y
3633a3656
> CONFIG_JOYSTICK_SEESAW=m
3720a3744
> CONFIG_KVM_COMMON=y
3724a3749,3751
> CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES=y
> CONFIG_KVM_GENERIC_MMU_NOTIFIER=y
> CONFIG_KVM_GENERIC_PRIVATE_MEM=y
3725a3753
> CONFIG_KVM_HYPERV=y
3729a3758
> CONFIG_KVM_PRIVATE_MEM=y
3730a3760
> CONFIG_KVM_SW_PROTECTED_VM=y
3845c3875
< CONFIG_LOCALVERSION="-1-default"
---
> CONFIG_LOCALVERSION="-1.g9b23bf2-default"
3864a3895
> CONFIG_LRU_GEN_WALKS_MMU=y
3923a3955
> CONFIG_MCP9600=m
3929d3960
< CONFIG_MD_FAULTY=m
3940d3970
< CONFIG_MD_LINEAR=m
4125a4156
> CONFIG_MLX90635=m
5018d5048
< CONFIG_NORTEL_HERMES=m
5027a5058
> CONFIG_NSM=m
5059,5060d5089
< CONFIG_NVMEM_LAYOUT_ONIE_TLV=m
< CONFIG_NVMEM_LAYOUT_SL28_VPD=m
5098d5126
< CONFIG_ORINOCO_USB=m
5212d5239
< CONFIG_PCI_ATMEL=m
5234d5260
< CONFIG_PCI_HERMES=m
5257d5282
< CONFIG_PCMCIA_RAYCS=m
5259d5283
< CONFIG_PCMCIA_WL3501=m
5313a5338
> CONFIG_PINCTRL_INTEL_PLATFORM=m
5320a5346
> CONFIG_PINCTRL_METEORPOINT=m
5333d5358
< CONFIG_PLX_HERMES=m
5464a5490
> CONFIG_QCOM_PMIC_PDCHARGER_ULOG=m
5498a5525
> CONFIG_R8169_LEDS=y
5617a5645
> CONFIG_REGULATOR_NETLINK_EVENTS=y
5756a5785
> CONFIG_RTC_DRV_MAX31335=m
5771a5801
> CONFIG_RTC_DRV_TPS6594=m
6081a6112
> CONFIG_SENSORS_GIGABYTE_WATERFORCE=m
6167a6199
> CONFIG_SENSORS_MP2856=m
6171a6204
> CONFIG_SENSORS_MP5990=m
6339a6373
> CONFIG_SILICOM_PLATFORM=m
6385a6420
> CONFIG_SND_AMD_ASOC_ACP70=m
6614a6650
> CONFIG_SND_SOC_ES83XX_DSM_COMMON=m
6951a6988
> CONFIG_STACKDEPOT_MAX_FRAMES=64
7010d7046
< CONFIG_SUSE_KERNEL_RELEASED=y
7125d7160
< CONFIG_THERMAL_ACPI=y
7161d7195
< CONFIG_TMD_HERMES=m
7313a7348
> CONFIG_TYPEC_MUX_WCD939X_USBSS=m
7612d7646
< CONFIG_USB_NET_RNDIS_WLAN=m
7746d7779
< CONFIG_USB_ZD1201=m
7752d7784
< CONFIG_USERMODE_DRIVER=y
7819a7852
> CONFIG_VIDEO_ALVIUM_CSI2=m
7880a7914,7915
> CONFIG_VIDEO_GC0308=m
> CONFIG_VIDEO_GC2145=m
7941a7977
> CONFIG_VIDEO_OV64A40=m
7988a8025
> CONFIG_VIDEO_THP7312=m
8001a8039
> CONFIG_VIDEO_TW9900=m
8038a8077
> CONFIG_VIRTIO_PCI_ADMIN_LEGACY=y
8044a8084
> CONFIG_VIRTIO_VFIO_PCI=m
8083a8124
> CONFIG_W1_MASTER_AMD_AXI=m
8159d8199
< CONFIG_WLAN_VENDOR_CISCO=y
8206a8247
> CONFIG_X86_HAVE_PAE=y

[hungrymonkey]

sudo cat /proc/config.gz | zcat | sed  '/^#/d' | sort > config-`uname -r`

I created those config files above with this command.

[RodoMa92]

sudo cat /proc/config.gz | zcat | sed  '/^#/d' | sort > config-`uname -r`

I created those config files above with this command.

Sadly my kernel configuration has not enabled IKCONFIG, so I can't export that configuration like that and the sources for the packages are huge and with too much possible combinations to know exactly which one is picked at build time. I'll leave the sources if you want to dig in deeper: https://pagure.io/kernel-fsync/tree/6.7

[hungrymonkey]

Tested kernel 6.7.5

6.7.5-1.1.ga3bab56.x86_64
Name        : kernel-default
Version     : 6.7.5
Release     : 1.1.ga3bab56
Architecture: x86_64
Install Date: Sun 18 Feb 2024 07:01:32 AM PST
Group       : System/Kernel
Size        : 251191405
License     : GPL-2.0-only
Signature   : RSA/SHA256, Sat 17 Feb 2024 01:00:55 AM PST, Key ID eceef21003579c1d
Source RPM  : kernel-default-6.7.5-1.1.ga3bab56.nosrc.rpm
Build Date  : Sat 17 Feb 2024 12:53:43 AM PST
Build Host  : i01-ch1c
Vendor      : obs://build.opensuse.org/Kernel
URL         : https://www.kernel.org/
Summary     : The Standard Kernel
Description :
The standard kernel for both uniprocessor and multiprocessor systems.


Source Timestamp: 2024-02-17 07:45:40 +0000
GIT Revision: a3bab56f26c8c783bb4195c872ddc6b877982fa0
GIT Branch: stable
Distribution: Kernel:stable

https://download.opensuse.org/repositories/Kernel:/stable/standard/x86_64/

diff config-6.7.4-1-default config-6.7.5-1.ga3bab56-default

1318c1318
< CONFIG_CC_VERSION_TEXT="gcc (SUSE Linux) 13.2.1 20240125 [revision fc7d87e0ffadca49bec29b2107c1efd0da6b6ded]"
---
> CONFIG_CC_VERSION_TEXT="gcc (SUSE Linux) 13.2.1 20240206 [revision 67ac78caf31f7cb3202177e6428a46d829b70f23]"
3271,3273d3270
< CONFIG_INTEL_ATOMISP2_LED=m
< CONFIG_INTEL_ATOMISP2_PDX86=y
< CONFIG_INTEL_ATOMISP=y
3845c3842
< CONFIG_LOCALVERSION="-1-default"
---
> CONFIG_LOCALVERSION="-1.ga3bab56-default"
7010d7006
< CONFIG_SUSE_KERNEL_RELEASED=y
7822,7828d7817
< CONFIG_VIDEO_ATOMISP_GC0310=m
< CONFIG_VIDEO_ATOMISP_GC2235=m
< CONFIG_VIDEO_ATOMISP_LM3554=m
< CONFIG_VIDEO_ATOMISP=m
< CONFIG_VIDEO_ATOMISP_MSRLIST_HELPER=m
< CONFIG_VIDEO_ATOMISP_MT9M114=m
< CONFIG_VIDEO_ATOMISP_OV2722=m

I think I might close this issue.

[hungrymonkey]

Speaker works in kernel 6.7.5.