Invert m_mat4HMDPose after assignment copying. #135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erting the value in m_rmat4DevicePose[vr::k_unTrackedDeviceIndex_Hmd]; Matrix4.invert() works on the reference causing the original value to also be modified.
Contributor
|
Thanks, we've committed this internally and it will be updated in the next API release. |
jeremyselan
added a commit
that referenced
this pull request
Nov 16, 2016
General: * Further refinement to Vulkan support. Note: the interface is still subject to change. IVRSystem (v14): * ComputeDistortion signature change. Previous version used nan as error signaling. New version returns explicit success. * GetHiddenAreaMesh takes optional EHiddenAreaMeshType argument to request Standard, Inverse, or LineLoop mesh. IVRCompositor (v18): * New submit error, VRCompositorError_AlreadySubmitted (if you submit the same eye twice) * GetFrameTimings signature change * Exposed GetCurrentFadeColor, GetCurrentGridAlpha IVROverlay (v13): * Added SetOverlayIntersectionMask IServerDriverHost: * Added PollNextEvent IClientDriverHost: * Removed GetSettings * Added GetGenericInterface ClientTrackedDeviceProvider (v5): * GetHiddenAreaMesh takes additional argument, EHiddenAreaMeshType Pull Requests integrated: #48 Format README in Markdown #58 correct detection of GCC #68 helloworldoverlay: Specify c++11 to fix gcc errors #76 Remove duplicate, unneeded glBindBuffer call. #135 Invert m_mat4HMDPose after assignment copying. #191 Document additional methods #278 include stdbool.h on non windows platform #306 Multi-platform CMake support. [git-p4: depot-paths = "//vr/steamvr/sdk_release/": change = 3697868]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invert m_mat4HMDPose after assignment to avoid mutating or double inverting the value in m_rmat4DevicePose[vr::k_unTrackedDeviceIndex_Hmd];
Matrix4.invert() works on the reference causing the original value to also be modified.