Fixed runtime-created SteamVR_Behaviour instance not being set to DontDestroyOnLoad. #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We were also hit by this bug and discovered same solution independently. |
Collaborator
|
Going to fix this slightly differently. Thanks for the report and pull! |
keithbradner
added a commit
that referenced
this pull request
Jun 12, 2019
Changes for 2.3.1b * Added legacy mixed reality camera mode (enabled by default). You can change this in SteamVR/Resources/SteamVR_Settings. * Fixing some errors for 2019.1 * Removing an unused editor class * Added low fidelity fallback hand animation for when no skeleton data is available (WinMR) * Fixing OpenVR Package not required error for pre 2018.2 versions of unity * Fixed serializable event in Throwable * Fix for Custom Skeleton not getting initialized * Fix for a rare failure in action retrieval (#431) * Allowing folders in the action path. (#443) * Fix for multiple SteamVR_Behaviours initializing (#435) * Stop updating poses if they're not active
Collaborator
|
Thanks! This should be in the latest beta: https://github.com/ValveSoftware/steamvr_unity_plugin/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a missing local variable assignment in SteamVR_Behaviour.Initialize() that caused runtime-created SteamVR_Behaviours (the [SteamVR] game object) not being set to DontDestroyOnLoad.
That meant loading a new scene would destroy the game object and input and poses wouldn't update anymore.