i18n: translate the settlement-preview screen#38
Merged
Conversation
Localize the owner-only settlement-preview console screen (EN/Burmese): the batches table, the per-batch detail drawer (summary cards + matched-users table), and the approve/void confirmation modals (including the required void reason). Adds a `settlementPreview` namespace to both messages/en.ts and messages/my.ts, builds the status/period/date dropdown options and table columns inside the component so they read `t`, maps status keys to message keys via a STATUS_KEY object, and routes the SET-… batch id through a `batchIdFull` helper. Filter values stay in English. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Vance1832
added a commit
that referenced
this pull request
Jun 25, 2026
All owner screens are now bilingual (result-periods #34, ledgers #35, ledger-templates #36, result-entry #37, settlement-preview #38, company-reserve #39, user-management #40), completing the EN/Burmese localization across the whole app. Update HANDOFF.md and CLAUDE.md to reflect that no screens remain; the i18n pattern is retained as reference for any new screens. Real-time notifications is now the top remaining backlog item. Co-authored-by: Khant Zayar <khantzayar0073@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the EN/Burmese localization of the owner console — the settlement-preview screen.
What
settlementPreviewnamespace in bothmessages/en.tsandmessages/my.ts(Burmese type-checked against English).t.STATUS_KEYobject → message keys; reuses sharedcommon.status/filters.*. TheSET-…batch id routes through abatchIdFullhelper.Verification
npm run typecheck && npm run lint && npm test && npm run build— all green. Grepped the file for leftover capitalized literals (none).🤖 Generated with Claude Code