fix(web): allow public brand assets through middleware#37
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Excludes the public brand/logo asset and generated app icon URLs from the auth middleware matcher.\n- Keeps API, dashboard, and other protected application routes under the existing auth middleware.\n- Preserves the existing Next image optimizer exemption used by the login page logo.\n\n## Checks\n- PASS: corepack pnpm lint\n- PASS: DATABASE_URL=postgresql://user:pass@localhost:5432/db?schema=public AUTH_SECRET=placeholder corepack pnpm typecheck\n- PASS: DATABASE_URL=postgresql://user:pass@localhost:5432/db?schema=public AUTH_SECRET=placeholder corepack pnpm build\n\n## QA handoff\n- Verify unauthenticated GETs for /agentbridge-logo.jpg, /favicon.ico, /icon.png, /apple-icon.png return image content, not login HTML.\n- Verify the login page logo renders for unauthenticated users and dashboard logo remains working after auth.\n- This PR targets PR #36's branch so it can unblock that logo/favicon change.