Skip to content

Minor services improvement and extending features set#45

Merged
Vasar007 merged 41 commits into
masterfrom
develop
Aug 24, 2019
Merged

Minor services improvement and extending features set#45
Vasar007 merged 41 commits into
masterfrom
develop

Conversation

@Vasar007

Copy link
Copy Markdown
Owner

Changes list:

  • Refactored magic strings;
  • Added dummy top list editor page;
  • Created view model for toplist editor view;
  • Refactored desktop and config options.
  • Refactored contract and options;
  • Removed any CPU configuration from solution;
  • Simplified view model names;
  • Added default values for settings varibables that can be read from system environment variables;
  • Added new views and view models for toplist editor;
  • Added default values for environment variables;
  • Updated NuGet packages;
  • Removed old style package.config;
  • Removed extra links to packages in some projects;
  • Added user control for toplist item;
  • Extended utilities extensions methods class;
  • Fixed typos and style error in doc strings;
  • Specified proper type for null string case;
  • Simplified Thing class model;
  • Added additional observable collections;
  • Renamed ResponseMetaData -> ResponseMetadata;
  • Updated some packages;
  • Implemented logic to work with toplist items;
  • Unified XAML style in views;
  • Placed private static methods after public isntance methods;
  • Removed button triggers (may be return later);
  • Renamed project DTO -> Models;
  • Refactored RelayCommand;
  • Improved UI and fixed some UI bugs;
  • Extended IEnumerable extensions;
  • Added serializable attribute to models;
  • Specified build platfrom for desktop app;
  • Created dummy credentials.json for CI;
  • Fixed typo in README;
  • Unified namespaces by code convention;
  • Fixed incorrect check for TMDB config image value;
  • Added ILogger interface to provide more flexible way to work with logging later;
  • Improved log messages and make it easier to read;
  • Added new layouts for NLog;
  • Added header and footer messages;
  • Changed logging mode to async;
  • Added newlines for footer and header in logging;
  • Added option to control newline replacement in exception messages for logging;
  • Added PrintFooter methods fot ILogger;
  • Added "sealed" qualifier for all classes where it is not required that class could be used as base;
  • Changed acess level for method and specify call to base static method with same name
  • Renamed folder: Library -> Libraries;
  • Removed extra calls to logger for exceptional cases;
  • Updated NuGet packages;
  • Created projects for external services to avoid code mash.
  • Added adapters for external libs;
  • Simplified Dispose method for all disposable classes;
  • Added exception handling for external dependencies in adapters;
  • Changed own string equals method to standard call.

Closing issues

Close #41;
Close #42;
Close #43;
Close #44.

Vasar007 added 30 commits July 7, 2019 00:59
Add dummy top list editor page.
Refactor desktop and config options.
Remove any CPU configuration from solution;
Simplify view model names;
Add new views and view models for toplist editor.
Remove old style package.config;
Remove extra links to packages in some projects.
Add user control for toplist item.
Fix typos and style error in doc strings;
Specify proper type for null string case;
Add Toplist class model;
Simplify Thing class model.
Add new simple and score toplist models;
Rename ResponseMetaData -> ResponseMetadata.
Implement basic logic to work with toplist items (without loading from source);
Unify XAML style in views;
Place private static methods after public isntance methods.
Simplify work with toplist items.
Refactor RelayCommand;
Implement toplist block creation;
Improve UI.
Add load from file option for toplist view;
Add serializable attribute to models.
Add header and footer messages;
Change logging mode to async.
Remove unnecessary argument in CalcuilateInsertIndex for SimpleToplist.
Fix paths after Library folder reanaming;
Create projects for external services to avoid code mash.
Remove setters from ToplistBase format and type properties;
Simplify Dispose method for all disposable classes
Add exception handling for external dependencies in adapters;
Change own string equals method to standard call.
@Vasar007 Vasar007 added type: Bug Something isn't working type: Feature New feature or request type: Code Maintenance New feature/requirement which is targeting on improve architecture, realization and code style labels Aug 24, 2019
@Vasar007 Vasar007 added this to the 1.0 milestone Aug 24, 2019
@Vasar007 Vasar007 self-assigned this Aug 24, 2019
@Vasar007
Vasar007 merged commit 233eb66 into master Aug 24, 2019
@Vasar007
Vasar007 deleted the develop branch August 24, 2019 21:19
@Vasar007 Vasar007 modified the milestones: 1.0, 0.9.5 Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: Bug Something isn't working type: Code Maintenance New feature/requirement which is targeting on improve architecture, realization and code style type: Feature New feature or request

Projects

None yet

1 participant