Skip to content

Release 0.9.5#57

Merged
Vasar007 merged 155 commits into
masterfrom
develop
Jan 4, 2020
Merged

Release 0.9.5#57
Vasar007 merged 155 commits into
masterfrom
develop

Conversation

@Vasar007

@Vasar007 Vasar007 commented Jan 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Owner

Main changes

  • Migrated to .NET Core 3.0 WPF;
  • Migrated to .NET Standard 2.1;
  • Switched C# language version to 8.0;
  • Updated packages which can be used with .NET Core 3.0 and .NET Standard;
  • Total renaming: add ThingAppraiser prefix for all projects;
  • Enabled nullable reference types for desktop solution and fix all warnings;
  • Treated warnings for nullable reference as errors;
  • Updated packages and install Prism;
  • Used Prism EventAggregator instead of direct messages;
  • Used Acolyte.NET library.

Fixes

  • Removed Serializable attribute for DTO because of serialization errors;
  • Fixed invalid NLog config options;
  • Fixed output messages;
  • Fixed equals check with empty string;
  • Fixed bug with incorrect calculation of toplist block index to insert;
  • Resolved issue with unhandled exceptions from async crawlers;
  • Added equality operators for model classes;
  • Added validation to thing name text box;
  • Refactored input thing dialog and enter data dialog;
  • Refactored remaining dialogs to work through MaterialDesign calls;
  • Removed global dialog identifier;
  • Transformed InputThing dialog to local dialog without additional workload.

New Features

  • Created tests project for Appraisers and ContentDirectory assemblies;
  • Created TaskService project to execute service tasks;
  • Refactored TPL Dataflow pipeline logic;
  • Wrapped all pipeliene methods with try-catch and log all exceptions;
  • Enabled structured logging in NLog.

Other changes

  • Added padding for thread ID in logging files;
  • Created Building project and move service builders to it;
  • Replaced List with IReadOnlyList type;
  • Split implementation of sending request for request in Telegram chat;
  • Added IDisposable for crawlers manager;
  • Added icon for DesktopApp;
  • Removed own version of RelayCommand;
  • Split clear method for InputThingView to avoid selector parameter;
  • Added additional external layer which transforms C# values to F# internals;
  • Aligned all content item infos by title length;
  • Added option to open local path and select file in explorer;
  • Created MainWindow with ViewModelLocator and add data context to XAML;
  • Simplified async execution logic in main window view model;
  • Updated Visual Studio image version for CI;
  • Updated README;
  • Updated license info.

Resolved issues

Closed #46;
Closed #47;
Closed #49;
Closed #52;
Closed #56.

Vasar007 added 30 commits August 25, 2019 00:19
@Vasar007
Switch C# language version to 8.0;
6cd6cbd 
Switch .NET Core version to 3.0;
Enable null reference types and fix all warnings;
Use new using statement;
Disable endpoint routing in MVC settings.
@Vasar007
Remove Serializable attribute for DTO because of serialization errors;
f7d01ee 
Switch back to NewtonSoft.JsonNET because new System.Text.Json does not work properly with current DTO classes;
Extend logging for web-services.
@Vasar007
Add padding for thread ID in logging files
d6daba0
@Vasar007
Total renameing: add ThingAppraiser prefix for all projects
cdcf1bd
@Vasar007
Fix invalid NLog config options
cd3db9a
@Vasar007
Add equaltiy operators for model classes
70c3ea2
@Vasar007
Add common test project (using xUnit)
d1e93b9
@Vasar007
Extend model serialization test
694ba00
@Vasar007
Update Visual Studio image version
cd3df1f
@Vasar007
Update README
c4f1c4a
@Vasar007
Change Visual Studio 2019 to Preview version
5e512a0
@Vasar007
Remove empty spaces
37b5ca7
@Vasar007
Add email notifications on failures
417f23f
@Vasar007
Use global account settings for notifications
5da8ba0
@Vasar007
Add option to install .NET Core 3.0 Preview
b7f6d2c
@Vasar007
Create credentials.json
00b635f
@Vasar007
Create credentials.json
c248b97
@Vasar007
Delete credentials.json
c5faa12
@Vasar007
Delete credentials.json
56b6689
@Vasar007
Skip test because of JsonSerializer from .NET Core 3.0 issue with imm…
750581e 
…utable models
@Vasar007
Merge branch 'develop' of https://github.com/Vasar007/ThingAppraiser …
be59eb1 
…into develop
@Vasar007
Fix invalid path to ignore files
afb943b
@Vasar007
Ignore credentials file
cb39b4b
@Vasar007
Try to remove credentials file again
00bb437
@Vasar007
Return old version of path
09ad889
@Vasar007
Treat warnings for nullable reference as errors
d55bc90
@Vasar007
Enable nullable reference types for desktop solution and fix all warn…
95245ac 
…ings;

Add comment in places where using null-forgiving operator (!).
@Vasar007
Change basic info GetHashCode implementation (retrun ThingId.GetHashC…
3341425 
…ode() instead of plain ThindId);

Add equality members for rating model.
@Vasar007
Code cleanup and first attempt to use EF Core
f023eec
@Vasar007
Create Building project and move service builders to it;
ed8019b 
Create configuration project and move all config classes to it.
@Vasar007
Fix ContentFinder Tests
0555edd
@Vasar007
Treat more null-reference warnings as Errors
7e6d70f
@Vasar007
Try to execute tests explicitly
5f15fd6
@Vasar007
Another try to execute F# tests
b4d3e09
@Vasar007
Try #3 to execute F# tests
4c2abfe
@Vasar007
Fix invalid config arg for dotnet test in build script
062d3b3
@Vasar007
Try to use cinfiguration evn var
0d8f7a5
@Vasar007
Try to execute F# tests with proper configuration flag
154d055
@Vasar007
Try to place test script in yaml file
32c1b2c
@Vasar007
Fix YAML format
ada5623
@Vasar007
Try to break F# tests
603bddc
@Vasar007
Fix broken F# test
1d61500
@Vasar007
Add Path property name to title in main window view
5bb0a72
@Vasar007
Simplify async execution logic in main window view model
045cb18
@Vasar007
Update NuGet packages
85eb74c
@Vasar007
Update licanse, readme and projects' configurations
a5295e6
@Vasar007
Update LICENSE
614be4e
@Vasar007
Update LICENSE
54c61ef
@Vasar007
Update README
f74a55d
@Vasar007
Update license info
68c4c8b
@Vasar007
Fix license info
45ac7f9
@Vasar007
Use Acolyte.NET library
6bfe525
@Vasar007 Vasar007 added type: Bug Something isn't working type: Feature New feature or request type: Code Maintenance New feature/requirement which is targeting on improve architecture, realization and code style labels Jan 4, 2020
@Vasar007 Vasar007 added this to the 0.9.5 milestone Jan 4, 2020
@Vasar007 Vasar007 self-assigned this Jan 4, 2020
@Vasar007
Vasar007 merged commit 2c7fb33 into master Jan 4, 2020
@Vasar007
Vasar007 deleted the develop branch January 4, 2020 17:51
@Vasar007
Vasar007 restored the develop branch January 4, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Vasar007 Vasar007

Labels

type: Bug Something isn't working type: Code Maintenance New feature/requirement which is targeting on improve architecture, realization and code style type: Feature New feature or request

Projects

None yet

Milestone

v0.9.5

1 participant

@Vasar007