Guard g_debuggerControllers for concurrent access#1017
Merged
Conversation
xusheng6
force-pushed
the
test_guard_controller_list
branch
from
1acd8c4 to
ea7751d
Compare
Replace the raw pointer + manual realloc/placement-new with a heap-allocated ControllerState struct (mutex + vector), accessed via a function-local static pointer. This fixes potential data races when multiple threads call GetController, DeleteController, or ControllerExists concurrently. The ControllerState is intentionally leaked (never freed) so the mutex remains valid even during late cleanup -- e.g., Python's GC calling Destroy() via FFI after static destruction has begun. Fix #1016 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xusheng6
force-pushed
the
test_guard_controller_list
branch
from
ea7751d to
17c370c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
g_debuggerControllerspointer + manualrealloc/placement-new with a function-local staticstd::vectorreturned byGetControllers(), avoiding the static initialization order fiascostd::mutex g_controllerMutexwithlock_guardin all 6 accessor functions (GetController,DeleteController,ControllerExistsfor bothBinaryViewRefandFileMetadataRefoverloads) to prevent data races on concurrent accessFix #1016
Test plan
🤖 Generated with Claude Code