Fix crash in CorelliumAdapter::BreakInto when m_rspConnector is null#1073
Merged
Conversation
Mirror the null check that GdbAdapter::BreakInto already performs to avoid dereferencing m_rspConnector before the adapter is fully connected or after it has been torn down. Fixes #1066 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!m_isTargetRunning || !m_rspConnectorguard toCorelliumAdapter::BreakIntothatGdbAdapter::BreakIntoalready has, preventing a null-pointer dereference inRspConnector::SendRaw.EXCEPTION_ACCESS_VIOLATION_READ / 0x50atrspconnector.cpp:223reached viaCorelliumAdapter::BreakInto.Fixes #1066
Fixes BINARYNINJA-3X
Sentry context
binaryninja@5.3.9434m_rspConnectoris still null and the unconditionalSendRawcrashes. The0x50faulting address is consistent with a nullthisderef reading a field at offset 0x50 insideRspConnector.Test plan
🤖 Generated with Claude Code