Skip to content

Add missing m_rspConnector null checks in WriteMemory and TTD call query #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xusheng6 merged 1 commit into from
May 14, 2026
+5 −2
Merged

Add missing m_rspConnector null checks in WriteMemory and TTD call query #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/adapters/esrevenadapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ DataBuffer EsrevenAdapter::ReadMemory(std::uintptr_t address, std::size_t size)

bool EsrevenAdapter::WriteMemory(std::uintptr_t address, const DataBuffer& buffer)
{
if (m_isTargetRunning)
if (m_isTargetRunning || !m_rspConnector)
return false;

size_t size = buffer.GetLength();
Expand Down Expand Up @@ -2926,6 +2926,9 @@ std::vector<TTDCallEvent> EsrevenAdapter::GetTTDCallsForSymbols(const std::strin
return events;
}

if (!m_rspConnector)
return events;

// Get settings
auto adapterSettings = GetAdapterSettings();
BNSettingsScope scope = SettingsResourceScope;
Expand Down
2 changes: 1 addition & 1 deletion core/adapters/gdbadapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ DataBuffer GdbAdapter::ReadMemory(std::uintptr_t address, std::size_t size)

bool GdbAdapter::WriteMemory(std::uintptr_t address, const DataBuffer& buffer)
{
if (m_isTargetRunning)
if (m_isTargetRunning || !m_rspConnector)
return false;

size_t size = buffer.GetLength();
Expand Down