Narrow catch blocks in DebuggerInfoTable to ReadException#1081
Merged
Conversation
Per review feedback on #1079: catch the specific exception type (BinaryNinja::ReadException) instead of catch (...) when the throwing API is known. The original catch-all could swallow unrelated failures and hide intent. ReadException is the only exception BinaryReader::Seek and ReadPointer raise here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch (...)withcatch (const ReadException&)in the three try blocks added aroundBinaryReader::Seek+ReadPointer.BinaryNinja::ReadException(binaryninjaapi.h:8780) is the specific exception both APIs throw, so the narrow catch documents intent and lets unrelated failures (allocation errors, etc.) propagate where they can be diagnosed.Test plan
🤖 Generated with Claude Code