Show active thread first in stack trace view#827
Merged
Conversation
Co-authored-by: xusheng6 <94503187+xusheng6@users.noreply.github.com>
|
|
Copilot
AI
changed the title
[WIP] Active thread should be on top in the stack trace view
Show active thread first in stack trace view
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When debugging programs with many threads, users had to scroll through the stack trace view to find the active thread, which was displayed in arbitrary order along with other threads. This made debugging multi-threaded applications inefficient and frustrating.
This PR modifies the thread display order in the stack trace view so that the active thread always appears at the top of the list, providing immediate access to the most relevant debugging information.
Changes Made
ThreadFrameModel::updateRows()inui/threadframes.cppto sort threads before displaying them#include <algorithm>header to support the sorting functionalityImplementation Details
The sorting uses a custom comparator that:
controller->GetActiveThread().m_tid) firstBenefits
Fixes #726.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.