Fix #984: Refresh view after TTD coverage analysis completes#986
Merged
Fix #984: Refresh view after TTD coverage analysis completes#986
Conversation
- Pass UIContext to TTDAnalysisDialog for proper view access - Add refreshViewAndEnableRenderLayer() method to refresh view - Call refresh after analysis completes and after loading results - Verify TTD Coverage render layer is registered This makes coverage highlights visible immediately after analysis, assuming the user has the TTD Coverage render layer enabled. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Change render layer registration to AlwaysEnabled instead of DisabledByDefault - Add early return check: if GetExecutedInstructionCount() == 0, return immediately - This makes the layer have zero overhead when there's no coverage data - Simplify refreshViewAndEnableRenderLayer() method With these changes: - Users don't need to manually enable the render layer - Coverage is visible immediately after analysis completes - No performance impact when coverage data is not loaded - Works across all views (linear, graph, etc.) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #984 by automatically refreshing the view after TTD coverage analysis completes or results are loaded from cache.
Changes
TTDAnalysisDialogconstructor to accept and storeUIContext*for proper view accessrefreshViewAndEnableRenderLayer()method that:UIContext::refreshCurrentViewContents()to trigger view refreshui.cppto pass the UIContext fromUIActionContextBehavior
After coverage analysis completes or is loaded, the view will automatically refresh to display the coverage highlights (assuming the user has the "TTD Coverage" render layer enabled in View menu).
Test Plan
🤖 Generated with Claude Code