fix: propagate FontFlags::SYMBOLIC to TrueType glyph resolver#126
Merged
fix: propagate FontFlags::SYMBOLIC to TrueType glyph resolver#126
Conversation
Read the /Flags entry from the font descriptor and store it on TrueTypeFont. Pass FontFlags::SYMBOLIC through to TrueTypeFontRenderer so that resolve_simple_gid_impl can correctly gate fallback behaviour: non-symbolic fonts return None when no cmap entry is found (skip draw, advance with .notdef metrics); symbolic fonts fall back to treating the char code as a raw glyph index. Also give Standard 14 fallback fonts a default StandardEncoding so that simple char-code → glyph-name lookups work without an explicit /Encoding entry in the PDF. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Velli20
force-pushed
the
fix-symbolic-font
branch
from
52958ac to
b27e5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the /Flags entry from the font descriptor and store it on TrueTypeFont. Pass FontFlags::SYMBOLIC through to TrueTypeFontRenderer so that resolve_simple_gid_impl can correctly gate fallback behaviour: non-symbolic fonts return None when no cmap entry is found (skip draw, advance with .notdef metrics); symbolic fonts fall back to treating the char code as a raw glyph index.
Also give Standard 14 fallback fonts a default StandardEncoding so that simple char-code → glyph-name lookups work without an explicit /Encoding entry in the PDF.