Add concatenate_nth_power for NFTs - #682
Merged
Merged
Conversation
Collaborator
|
Thanks. Make the PR against master, please. Now, master is the main branch and devel is truly an in-development branch for, e.g., the discussed refactor of the library before it is fully ready to be published. |
Adda0
requested changes
Jul 17, 2026
Adda0
left a comment
Adda0
left a comment
Collaborator
There was a problem hiding this comment.
Looks good overall.
Could you also add some quick tests?
Collaborator
|
P.S.: You included all commits from devel. |
jurajsic
force-pushed
the
nft_concatenate_nth_power
branch
from
July 17, 2026 09:30
1e4cd1d to
957690e
Compare
Member
Author
|
Will you merge? |
Collaborator
|
I was waiting for the tests. Could you add some? |
jurajsic
force-pushed
the
nft_concatenate_nth_power
branch
from
July 21, 2026 23:10
c29da8b to
4ff8303
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concatenate_nth_powerwas defined only for NFAs, now it is also defined for NFTs.