Guard against duplicate xunit attachment names#1783
Merged
Conversation
A test can add the same received file as an attachment more than once — e.g. several failing Verify calls that share a received name via DisableRequireUniquePrefix. xunit's AddAttachment throws on a duplicate name, surfacing as an ArgumentException instead of the expected VerifyException. Skip the add when the name is already attached.
This was referenced Jul 9, 2026
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test can add the same received file as an attachment more than once — e.g. several failing Verify calls that share a received name via DisableRequireUniquePrefix. xunit's AddAttachment throws on a duplicate name, surfacing as an ArgumentException instead of the expected VerifyException. Skip the add when the name is already attached.