Nest snapshots by updating the SDK's None items - #1911
Merged
Conversation
Verify.AfterMicrosoftNetSdk.props added a None item per snapshot to carry DependentUpon, on top of the item the SDK's **/* glob had already produced. So every snapshot sat in None twice. DotNetProjectFile.Analyzers copies @(None) into Content for its SonarQube integration in non-IDE builds, which turned those into duplicate Content items and failed the build with NETSDK1022. The metadata is now applied with None Update to the SDK's item. The Include remains only for snapshots the SDK did not glob, such as when default items are disabled. FileNestingTests run the SDK's CheckForDuplicateItems target alongside the item evaluation, fail on any file listed twice, and cover a project that promotes None to Content as well as one that declares html snapshots as Content itself. VerifyTests/Verify.Bunit#108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify.AfterMicrosoftNetSdk.props added a None item per snapshot to carry DependentUpon, on top of the item the SDK's */ glob had already produced. So every snapshot sat in None twice. DotNetProjectFile.Analyzers copies @(None) into Content for its SonarQube integration in non-IDE builds, which turned those into duplicate Content items and failed the build with NETSDK1022.
The metadata is now applied with None Update to the SDK's item. The Include remains only for snapshots the SDK did not glob, such as when default items are disabled.
FileNestingTests run the SDK's CheckForDuplicateItems target alongside the item evaluation, fail on any file listed twice, and cover a project that promotes None to Content as well as one that declares html snapshots as Content itself.
VerifyTests/Verify.Bunit#108