Record the human-verified cancel tasks, and run apply on Copilot ACP - #211
Merged
Merged
Conversation
Three loose ends, none of which a machine could have closed on its own. `cancel-reports-what-happened` 6.5 and 7.6 are marked human-only in their own text: reproduce the original report against a real `copilot-cli-acp` run, cancel it, and confirm the agent's process actually stops with no stray "cancel" entry left in Processes. Both were carried out and confirmed by hand; this records that. `harness-git-stage-no-agent`: "premise" replaces "written" in 5.3's description of what the diff shows, and 5.3 now names the mechanism 5.4's regression test uses — it derives the no-agent stages from `CHAIN_STAGE_COMMAND` and asserts `HarnessStepAgentStage` excludes each of them, so a future stage cannot recreate the same type-versus-display mismatch unnoticed. `openspec/agent-harness.json` runs `apply` on `copilot-cli-acp` with `claude-sonnet-5`, which is what this repository has been using in practice. The `stepAgents.git` entry drafted alongside it is not included: `git` is a mechanical stage that never invokes an agent, so the loader drops the key on every read and logs a migration warning while doing it — it appeared three times in one local test run. A file also gained back its trailing newline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three loose ends, kept separate from #210 because none of them is code.
Human-verified tasks
cancel-reports-what-happened6.5 and 7.6 are marked human-only in theirown text: reproduce the original report against a real
copilot-cli-acprun, cancel it, and confirm the agent's process actually stops with no
stray "cancel" entry left behind in Processes. Both were carried out and
confirmed by hand. This records that; no agent could have closed them.
A correction, and what backs it
harness-git-stage-no-agent5.3: "premise" replaces "written" in thedescription of what the diff shows, and the task now names the mechanism
5.4's regression test actually uses — it derives the no-agent stages from
CHAIN_STAGE_COMMANDand assertsHarnessStepAgentStageexcludes each ofthem, so a future stage cannot recreate the same type-versus-display
mismatch unnoticed.
Config
openspec/agent-harness.jsonrunsapplyoncopilot-cli-acpwithclaude-sonnet-5— what this repository has been using in practice.The
stepAgents.gitentry drafted alongside it is deliberately notincluded.
gitis a mechanical stage that never invokes an agent, sothe loader drops the key on every read and logs a migration warning while
doing it — it appeared three times in a single local test run. Committing
it would have made that noise permanent for everyone while changing
nothing. The file also gets its trailing newline back.
🤖 Generated with Claude Code