feat(letter-categories): implement EV5-1-S1 letter categories - #69
Closed
hanchan-dev wants to merge 2 commits into
Closed
feat(letter-categories): implement EV5-1-S1 letter categories#69hanchan-dev wants to merge 2 commits into
hanchan-dev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementasi EV5-1-S1 untuk fitur Letter Categories sesuai TDD dan API Specification v5.
Migration, repository, endpoint, dan test untuk
letter_categoriestelah disiapkan sesuai kontrak yang ditentukan.Jira Ticket
Ticket:
EV5-1-S1Type of Change
Changes Made
LetterCategorysesuai strukturletter_categoriespada TDD.LetterCategoryRepositorydengan methodall(),findAllActive(), danfindByCode()sesuai Class Diagram.GET /letter-categoriessesuai API Specification v5.approval_normal,upload_mandiri,dokumen_pendukung, danupdate_data.code, dan boolean castis_active.How to Test
php artisan testScreenshots (if applicable)
Not applicable — perubahan ini tidak mencakup UI.
Checklist
console.log/dd()/dump()yang tertinggaldev(bukan langsung kemain)