Add ParticleSystem value formats - #54
Merged
Merged
Conversation
|
| Filename | Overview |
|---|---|
| crates/analysis/src/completion.rs | Adds snippets and distribution-member completions for structured ParticleSystem random variables and keyframes. |
| crates/analysis/src/diagnostics.rs | Adds validation for random-variable bounds, distributions, and ParticleSystem alpha/color keyframes. |
| crates/analysis/src/semantic.rs | Classifies ParticleSystem structured values as numbers or enum members. |
| crates/schema/schema.json | Converts ParticleSystem parser-backed unknown values to concrete random-variable and keyframe schema types. |
| crates/schema/src/lib.rs | Introduces schema enum variants for ParticleSystem structured values and updates token-position helpers. |
| crates/analysis/tests/spec/ParticleSystemValues.ini | Adds a focused fixture for ParticleSystem value completion and diagnostic behavior. |
| crates/analysis/tests/spec/ParticleSystemValues.spec.toml | Asserts distribution completions and invalid value diagnostics for the new ParticleSystem value handling. |
Reviews (2): Last reviewed commit: "Fix ParticleSystem keyframe semantic tok..." | Re-trigger Greptile
Owner
Author
ViTeXFTW
marked this pull request as ready for review
July 18, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
ParticleSystem fields using custom engine parsers were stored as
Unknown, so value completions and diagnostics were disabled.Impact
ParticleSystem values now receive engine-faithful validation and completion support, including optional distribution names.
Validation
cargo fmt --all -- --checkcargo test