Skip to content

WIP: remove patched openssl crate, use upstream API for TLS security profiles#248

Open
vparfonov wants to merge 1 commit intoViaQ:v0.54.0-rhfrom
vparfonov:remove-openssl-patch
Open

WIP: remove patched openssl crate, use upstream API for TLS security profiles#248
vparfonov wants to merge 1 commit intoViaQ:v0.54.0-rhfrom
vparfonov:remove-openssl-patch

Conversation

@vparfonov
Copy link
Copy Markdown

Replace the forked patch/openssl crate with direct calls to the upstream openssl crate's public API (set_min_proto_version, set_cipher_list, set_ciphersuites). This eliminates ~70 patched files and reduces the maintenance burden on upstream version bumps while preserving dynamic linking to system OpenSSL for FIPS compliance.

The TLS security profile logic (min_tls_version, ciphersuites) is now implemented in Vector's own TLS module via apply_tls_security_profile(), and is wired into apply_context_base() where it was previously stored but never applied in production code.

@vparfonov
Copy link
Copy Markdown
Author

/hold

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vparfonov
Once this PR has been reviewed and has the lgtm label, please assign xperimental for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from Clee2691 and cahartma April 3, 2026 11:40
…profiles (LOG-3398)

Replace the forked patch/openssl crate with direct calls to the upstream
openssl crate's public API (set_min_proto_version, set_cipher_list,
set_ciphersuites). This eliminates ~70 patched files and reduces the
maintenance burden on upstream version bumps while preserving dynamic
linking to system OpenSSL for FIPS compliance.

The TLS security profile logic (min_tls_version, ciphersuites) is now
implemented in Vector's own TLS module via apply_tls_security_profile(),
and is wired into apply_context_base() where it was previously stored
but never applied in production code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vparfonov vparfonov force-pushed the remove-openssl-patch branch from 144ebec to 6cb862d Compare April 3, 2026 12:28
@vparfonov
Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant