Extend install-proto script to use local file from Hermeto#274
Extend install-proto script to use local file from Hermeto#274xperimental wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xperimental The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test cluster-logging-operator-e2e |
|
/lgtm |
|
/test cluster-logging-operator-e2e |
|
/retest-required |
1 similar comment
|
/retest-required |
|
@xperimental: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jcantrill It looks like the "TLS scanner" test is timing out. Is that something that would be affected by a change to the ART Dockerfile or the script? (can't think of a connection myself) Does it make sense to override the test if the failure is not valid? |
This PR extends the
install-proto.shscript used by vector so that it checks if the required zip-file is already available in a pre-defined location which is used by Cachi2/Hermeto, the dependency fetcher of our downstream build. If the file is available locally, it is not downloaded from github.Required by openshift-eng/ocp-build-data#10574
/cc @vparfonov
/assign @jcantrill
/label tide/merge-method-squash