Skip to content

Extend install-proto script to use local file from Hermeto#274

Open
xperimental wants to merge 3 commits into
v0.54.0-rhfrom
protoc-hermeto
Open

Extend install-proto script to use local file from Hermeto#274
xperimental wants to merge 3 commits into
v0.54.0-rhfrom
protoc-hermeto

Conversation

@xperimental
Copy link
Copy Markdown

This PR extends the install-proto.sh script used by vector so that it checks if the required zip-file is already available in a pre-defined location which is used by Cachi2/Hermeto, the dependency fetcher of our downstream build. If the file is available locally, it is not downloaded from github.

Required by openshift-eng/ocp-build-data#10574

/cc @vparfonov
/assign @jcantrill
/label tide/merge-method-squash

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vparfonov
Copy link
Copy Markdown

/test cluster-logging-operator-e2e

@vparfonov
Copy link
Copy Markdown

/lgtm

@vparfonov
Copy link
Copy Markdown

/test cluster-logging-operator-e2e

@xperimental
Copy link
Copy Markdown
Author

/retest-required

1 similar comment
@xperimental
Copy link
Copy Markdown
Author

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

@xperimental: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/cluster-logging-operator-e2e f2bf778 link true /test cluster-logging-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xperimental
Copy link
Copy Markdown
Author

@jcantrill It looks like the "TLS scanner" test is timing out. Is that something that would be affected by a change to the ART Dockerfile or the script? (can't think of a connection myself)

Does it make sense to override the test if the failure is not valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants