Skip to content

Fix version comments, Unsubscribe from proprietary caching tier#4917

Merged
kennytv merged 2 commits intoViaVersion:masterfrom
Kichura:rs_fun_deploy
Apr 26, 2026
Merged

Fix version comments, Unsubscribe from proprietary caching tier#4917
kennytv merged 2 commits intoViaVersion:masterfrom
Kichura:rs_fun_deploy

Conversation

@Kichura
Copy link
Copy Markdown
Member

@Kichura Kichura commented Apr 22, 2026

  1. Fixes version comments by including v at beginning of them to resolve zizmor's versioning mismatch.
  2. Unsubscribes from Gradle's enhanced caching provider as it is proprietary and requires agreeing to Gradle's TOS.

@Kichura Kichura added the github_actions Pull requests that update GitHub Actions code label Apr 22, 2026
@Kichura Kichura requested a review from kennytv April 22, 2026 22:15
@kennytv
Copy link
Copy Markdown
Member

kennytv commented Apr 23, 2026

Caching shouldn't be disabled

@Kichura
Copy link
Copy Markdown
Member Author

Kichura commented Apr 23, 2026

Caching shouldn't be disabled

Did this intentionally as caching has a chance of causing builds to fail due to update conflicts. but can re-enable if it isn't an issue for this repo.

@kennytv kennytv merged commit 567ef33 into ViaVersion:master Apr 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants