VM_DISABLESELFSERVICESCRAPE/Spec.DisableSelfServiceScrape has no effect

[rrhubenov]

There seems to be a regression that was introduced with v0.66.0 of the operator. When deploying the following VLSingle Resource:

apiVersion: operator.victoriametrics.com/v1
kind: VLSingle
metadata:
  name: example
  namespace: garden
spec:
  disableSelfServiceScrape: true
  retentionPeriod: "12"
  storage:
    resources:
      requests:
        storage: 50Gi
  resources:
    requests:
      memory: 500Mi
      cpu: 500m
    limits:
      memory: 10Gi
      cpu: 5

The disableSelfServiceScrape fields seems to not work as intended. Logs from the operator:

...
{"level":"info","ts":"2026-01-07T15:55:13Z","logger":"controller.VLSingle","msg":"object has changes with previous state, applying changes","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:55:14Z","logger":"controller.VLSingle","msg":"creating new PVC vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:55:15Z","logger":"controller.VLSingle","msg":"creating new ServiceAccount vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:55:15Z","logger":"controller.VLSingle","msg":"creating new Service vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:55:16Z","logger":"controller.VLSingle","msg":"creating new Deployment vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"error","ts":"2026-01-07T15:55:30Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"3e3d38f9-ac8f-4477-83c8-3354224871f4","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-07T15:55:33Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"94a39003-e6fa-407f-964b-d9abe58eb14d","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-07T15:55:38Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"e6a524ce-7e52-4c65-beae-dab2caf903eb","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-07T15:55:47Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"a3a33f1f-6f53-4496-a8b2-e156a04ec601","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-07T15:56:04Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"ea08622d-fb25-4bde-8e54-dfa5055161c7","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-07T15:56:37Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"cde043fb-5de7-4fe7-a4da-d584c00ed477","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}

Adding VM_DISABLESELFSERVICESCRAPE=true to the env of the deployment seems to not fix the issue as well.
Easiest way to reproduce would be:

1. Deploy only the VLSingle CRD
2. Create a VictoriaOperator deployment or apply helm chart
3. Create a VLSingle custom resource with the disableSelfServiceScrape set to true

When doing the same with version 0.65 of the operator, everything works as expected:

{"level":"info","ts":"2026-01-07T15:44:46Z","logger":"manager","msg":"Starting EventSource","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","source":"kind source: *v1.Deployment"}
{"level":"info","ts":"2026-01-07T15:44:48Z","logger":"manager","msg":"Starting Controller","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle"}
{"level":"info","ts":"2026-01-07T15:44:48Z","logger":"manager","msg":"Starting workers","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","worker count":15}
{"level":"info","ts":"2026-01-07T15:52:03Z","logger":"controller.VLSingle","msg":"object has changes with previous state, applying changes","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:52:03Z","logger":"controller.VLSingle","msg":"creating new PVC vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:52:03Z","logger":"controller.VLSingle","msg":"creating new ServiceAccount vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:52:03Z","logger":"controller.VLSingle","msg":"creating new Service vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-07T15:52:03Z","logger":"controller.VLSingle","msg":"creating new Deployment vlsingle-example","vlsingle":"example","namespace":"garden"}

Let me know if any more info is needed!

[AndrewChubatiuk]

looks like vmservicescrape CRD is not installed. am i right?

[rrhubenov]

looks like vmservicescrape CRD is not installed. am i right?

Yes, I forgot to mention that for the specific use case, VLSingle is the only CRD that gets installed.
For this reason, we need to disable the self service scrape feature.

[AndrewChubatiuk]

this behaviour is expected. try disabling unneeded controllers using -controller.disableReconcileFor=VMServiceScrape,VMPodScrape flag. in victoria-metrics-operator helm chart it can be done using

extraArgs:
  controller.disableReconcileFor: VMServiceScrape,VMPodScrape

[rrhubenov]

I've already disabled all the controllers except the VLSingle one:

- args:
        - --leader-elect
        - --health-probe-bind-address=:8081
        - --metrics-bind-address=:8080
        - --controller.disableReconcileFor=VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster
        env:
        - name: WATCH_NAMESPACE
        - name: VM_ENABLEDPROMETHEUSCONVERTER_PODMONITOR
          value: "false"
        - name: VM_ENABLEDPROMETHEUSCONVERTER_SERVICESCRAPE
          value: "false"
        - name: VM_ENABLEDPROMETHEUSCONVERTER_PROMETHEUSRULE
          value: "false"
        - name: VM_ENABLEDPROMETHEUSCONVERTER_PROBE
          value: "false"
        - name: VM_ENABLEDPROMETHEUSCONVERTER_ALERTMANAGERCONFIG
          value: "false"
        - name: VM_ENABLEDPROMETHEUSCONVERTER_SCRAPECONFIG
          value: "false"
        - name: VM_DISABLESELFSERVICESCRAPECREATION
          value: "true"

The issue is with these specific lines of code

operator/internal/controller/operator/factory/vlsingle/vlsingle.go

Lines 322 to 326 in e300e9e

	if ptr.Deref(cr.Spec.DisableSelfServiceScrape, disableSelfScrape) {
	if err := finalize.SafeDeleteWithFinalizer(ctx, rclient, &vmv1beta1.VMServiceScrape{ObjectMeta: objMeta}, &owner); err != nil {
	return fmt.Errorf("cannot remove serviceScrape: %w", err)
	}
	}

On version v.0.65.0 it works as expected - that is it never tries to delete a VMServiceScrape CR since the cr.Spec.DisableSelfServiceScrape/VM_DISABLESELFSERVICESCRAPE are set to true. But it does not work the same way in v.0.66.0

[rrhubenov]

Here are the full victoria operator logs that show the controllers being disabled, if that helps:

{"level":"info","ts":"2026-01-08T13:18:03Z","logger":"setup","msg":"starting VictoriaMetrics operator build version: operator-20251203-212753-v0.66.0, short_version: v0.66.0"}
{"level":"info","ts":"2026-01-08T13:18:03Z","logger":"setup","msg":"Registering Components."}
{"level":"info","ts":"2026-01-08T13:18:03Z","msg":"starting CRD ownership controller"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VLAgent","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VTSingle","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMProbe","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMCluster","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAgent","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAnomaly","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAuth","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VTCluster","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMRule","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAlertmanagerConfig","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMServiceScrape","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VLogs","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAlertmanager","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMAlert","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMUser","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMPodScrape","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMStaticScrape","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMScrapeConfig","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VLCluster","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMNodeScrape","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"controller disabled by provided flag","name":"VMSingle","controller.disableReconcileFor":"VLAgent,VLCluster,VLogs,VMAgent,VMAlert,VMAlertmanager,VMAlertmanagerConfig,VMAnomaly,VMAuth,VMCluster,VMNodeScrape,VMPodScrape,VMProbe,VMRule,VMScrapeConfig,VMServiceScrape,VMSingle,VMStaticScrape,VMUser,VTSingle,VTCluster"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"setup","msg":"starting vmconverter clients"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"setup","msg":"using kubernetes server version: v1.33.7"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"setup","msg":"starting manager"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"controller-runtime.metrics","msg":"Starting metrics server"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"controller-runtime.metrics","msg":"Serving metrics server","bindAddress":":8080","secure":false}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"starting server","name":"pprof","addr":"[::]:8435"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"starting server","name":"health probe","addr":"[::]:8081"}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"attempting to acquire leader lease garden/57410f0d.victoriametrics.com..."}
{"level":"info","ts":"2026-01-08T13:18:04Z","msg":"successfully acquired lease garden/57410f0d.victoriametrics.com"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"manager","msg":"Starting EventSource","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","source":"kind source: *v1.Service"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"controller.PrometheusConverter","msg":"starting prometheus converter"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"controller.PrometheusConverter","msg":"waiting for prometheus converter to stop"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"manager","msg":"Starting EventSource","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","source":"kind source: *v1.VLSingle"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"manager","msg":"Starting EventSource","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","source":"kind source: *v1.Deployment"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"manager","msg":"Starting Controller","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle"}
{"level":"info","ts":"2026-01-08T13:18:04Z","logger":"manager","msg":"Starting workers","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","worker count":15}
{"level":"info","ts":"2026-01-08T13:20:48Z","logger":"controller.VLSingle","msg":"object has changes with previous state, applying changes","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-08T13:20:48Z","logger":"controller.VLSingle","msg":"creating new PVC vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-08T13:20:48Z","logger":"controller.VLSingle","msg":"creating new ServiceAccount vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-08T13:20:48Z","logger":"controller.VLSingle","msg":"creating new Service vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-08T13:20:48Z","logger":"controller.VLSingle","msg":"creating new Deployment vlsingle-example","vlsingle":"example","namespace":"garden"}
{"level":"info","ts":"2026-01-08T13:20:56Z","logger":"controller.VLSingle","msg":"object was successfully reconciled","vlsingle":"example","namespace":"garden"}
{"level":"error","ts":"2026-01-08T13:20:56Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"6dbad514-8cdf-47e1-8f05-65645c6b8337","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-08T13:20:58Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"9c775ecc-8575-4373-8e99-69e719895a2c","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}
{"level":"error","ts":"2026-01-08T13:21:02Z","logger":"manager","msg":"Reconciler error","controller":"vlsingle","controllerGroup":"operator.victoriametrics.com","controllerKind":"VLSingle","VLSingle":{"name":"example","namespace":"garden"},"namespace":"garden","name":"example","reconcileID":"7c224e80-50f9-4f2d-a00a-adf17103f122","error":"failed create or update vlsingle: cannot remove serviceScrape: no matches for kind \"VMServiceScrape\" in version \"operator.victoriametrics.com/v1beta1\""}

[AndrewChubatiuk]

well, right, this is a bug, need to add check if controller is enabled before creation/removal. with this change disableSelfServiceScrape should be ignored

[rrhubenov]

Since this works as intended in version v0.65.0, I believe this is a regression that has been added with version v0.66.0.
The lines of code here:

operator/internal/controller/operator/factory/vlsingle/vlsingle.go

Lines 322 to 326 in e300e9e

	if ptr.Deref(cr.Spec.DisableSelfServiceScrape, disableSelfScrape) {
	if err := finalize.SafeDeleteWithFinalizer(ctx, rclient, &vmv1beta1.VMServiceScrape{ObjectMeta: objMeta}, &owner); err != nil {
	return fmt.Errorf("cannot remove serviceScrape: %w", err)
	}
	}

Should completely bypass any action with the VMServiceScrape CR, as it does on version v0.65.0. Maybe the variables in this specific line don't have the expected value?:

ptr.Deref(cr.Spec.DisableSelfServiceScrape, disableSelfScrape)

Thank you for the help! :)

EDIT:
In version v0.65.0, the variable is used in two places:

operator/internal/controller/operator/factory/vlsingle/vlsingle.go

Lines 92 to 97 in 290bec0

	if !ptr.Deref(cr.Spec.DisableSelfServiceScrape, false) {
	err := reconcile.VMServiceScrapeForCRD(ctx, rclient, build.VMServiceScrapeForServiceWithSpec(svc, cr))
	if err != nil {
	return fmt.Errorf("cannot create serviceScrape for vlsingle: %w", err)
	}
	}

and

operator/internal/controller/operator/factory/vlsingle/vlsingle.go

Lines 343 to 347 in 290bec0

	if ptr.Deref(cr.Spec.DisableSelfServiceScrape, false) && !ptr.Deref(cr.ParsedLastAppliedSpec.DisableSelfServiceScrape, false) {
	if err := finalize.SafeDeleteWithFinalizer(ctx, rclient, &vmv1beta1.VMServiceScrape{ObjectMeta: objMeta}); err != nil {
	return fmt.Errorf("cannot remove serviceScrape: %w", err)
	}
	}

But both places correctly execute the deletion if the variable is false.

While in version v0.66.1, the check has been inverted in the deleteOrphaned function, which leads to the error:

operator/internal/controller/operator/factory/vlsingle/vlsingle.go

Lines 344 to 349 in 84a49bc

	disableSelfScrape := cfg.DisableSelfServiceScrapeCreation
	if ptr.Deref(cr.Spec.DisableSelfServiceScrape, disableSelfScrape) {
	if err := finalize.SafeDeleteWithFinalizer(ctx, rclient, &vmv1beta1.VMServiceScrape{ObjectMeta: objMeta}, &owner); err != nil {
	return fmt.Errorf("cannot remove serviceScrape: %w", err)
	}
	}