fix: skip self scrape objects management if respective controller is disabled #1721
+752
−707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewChubatiuk
requested review from
Haleygo,
f41gh7 and
vrutkovs
as code owners
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
2 times, most recently
from
51abb06 to
830a65d
Compare
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
from
830a65d to
29adf1d
Compare
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
from
29adf1d to
8e970fd
Compare
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
3 times, most recently
from
33e2bf5 to
14c3a19
Compare
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
from
14c3a19 to
87dcfb6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 51 out of 51 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewChubatiuk
requested review from
vrutkovs
and removed request for
Haleygo,
f41gh7 and
vrutkovs
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
from
87dcfb6 to
97e247a
Compare
AndrewChubatiuk
force-pushed
the
check-controller-status
branch
from
97e247a to
6511dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently if all scrape object controllers are disabled operator still tries to create/remove scrape objects. with this PR disabled controllers are checked before self scrape objects creation/removal for all CRs and converters
additionally:
fixes #1718