Skip to content

storageDataPath not working as expected for VMSingle #2586

Description

@nebula-it

storageDataPath docs mention that defining it would disables spec.storage option, but it does not seem to.

e.g Deploying this spec:

---
# Source: vm-stack/charts/vm-stack/templates/victoria-metrics-operator/vmsingle/vmsingle.yml
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMSingle
metadata:
  name: release-name-vm-stack
  namespace: victoria-metrics
  labels: 
    app.kubernetes.io/component: vmsingle
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: vm-stack
    app.kubernetes.io/version: v1.150.0
    helm.sh/chart: vm-stack-0.91.2
spec: 
  extraArgs:
    vmalert.proxyURL: http://vmalert-release-name-vm-stack.victoria-metrics.svc.cluster.local.:8080
  image:
    tag: v1.150.0
  port: "8428"
  replicaCount: 1
  resources:
    limits:
      memory: 2Gi
    requests:
      cpu: 100m
  retentionPeriod: 1y
  storage:
    accessModes:
    - ReadWriteOnce
    resources:
      requests:
        storage: 20Gi
  storageDataPath: /vmsingle-data
  volumeMounts:
  - mountPath: /vmsingle-data
    name: vm-single
    subPath: long-term
  volumes:
  - name: vm-single
    persistentVolumeClaim:
      claimName: vm-single

results in following error (kubectl describe vmsingles.operator.victoriametrics.com release-name-vm-stack) :
Warning ReconciliationError <unknown> victoria-metrics-operator failed create or update vmsingle: cannot generate prev deploy spec: unexpected volume="vm-single" mounted to path="/vmsingle-data", which is reserved for volume="data", path="/vmsingle-data"

Linked issue on helm chart side VictoriaMetrics/helm-charts#3195, as that is preventing us to not define storage: key at all.

Expected behavior

As per the docs, with storageDataPath: /vmsingle-data set, the storage: should have been ignored completely. Plus the value of storageDataPath should also be added to extraArgs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions