Skip to content

alertmanagerconfig: properly render negative numbers#2133

Merged
vrutkovs merged 1 commit intomasterfrom
fixed-alertmanagerconfig-negative-values
May 7, 2026
Merged

alertmanagerconfig: properly render negative numbers#2133
vrutkovs merged 1 commit intomasterfrom
fixed-alertmanagerconfig-negative-values

Conversation

@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk commented May 3, 2026

fixes #2132


Summary by cubic

Fixes ignored negative numbers in VMAlertmanagerConfig by rendering any non-zero numeric values. Restores support for fields like negative Telegram chat_id (fixes #2132).

  • Bug Fixes
    • Change config rendering to include ints/floats when value != 0 (was > 0).
    • Add test for negative Telegram chat_id to ensure it appears in YAML.
    • Update changelog entry for the bug.

Written for commit e2554db. Summary will update on new commits.

@AndrewChubatiuk AndrewChubatiuk requested a review from vrutkovs as a code owner May 3, 2026 13:53
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@vrutkovs vrutkovs merged commit 95da412 into master May 7, 2026
7 checks passed
@vrutkovs vrutkovs deleted the fixed-alertmanagerconfig-negative-values branch May 7, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Operator v0.69.0 cannot reconclile VMAlertmanager

2 participants