Skip to content

alertmanagerconfig: properly render negative numbers #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vrutkovs merged 1 commit into from
May 7, 2026
Merged

alertmanagerconfig: properly render negative numbers #2133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ aliases:

* BUGFIX: [converter](https://docs.victoriametrics.com/operator/integrations/prometheus/#objects-conversion): disable all prometheus controllers if CRD group was not found. See [#2838](https://github.com/VictoriaMetrics/helm-charts/issues/2838).
* BUGFIX: [vmdistributed](https://docs.victoriametrics.com/operator/resources/vmdistributed/): change default load balancing policy for write requests from `first_available` to `least_loaded`. This should allow to evenly distribute write load across all VMAgents.
* BUGFIX: [vmalertmanagerconfig](https://docs.victoriametrics.com/operator/resources/vmalertmanagerconfig/): fix previously ignored negative values in VMAlertmanagerConfig. See [#2132](https://github.com/VictoriaMetrics/operator/issues/2132).

## [v0.69.0](https://github.com/VictoriaMetrics/operator/releases/tag/v0.69.0)
**Release date:** 22 April 2026
Expand Down
8 changes: 4 additions & 4 deletions internal/controller/operator/factory/vmalertmanager/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,19 +246,19 @@ func (r *rawValue) set(k string, v any) {
r.items = append(r.items, yaml.MapItem{Key: k, Value: item})
}
case int:
if item > 0 {
if item != 0 {
r.items = append(r.items, yaml.MapItem{Key: k, Value: item})
}
case int32:
if item > 0 {
if item != 0 {
r.items = append(r.items, yaml.MapItem{Key: k, Value: item})
}
case int64:
if item > 0 {
if item != 0 {
r.items = append(r.items, yaml.MapItem{Key: k, Value: item})
}
case float64:
if item > 0 {
if item != 0 {
r.items = append(r.items, yaml.MapItem{Key: k, Value: item})
}
case bool:
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/operator/factory/vmalertmanager/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ templates: []
TelegramConfigs: []vmv1beta1.TelegramConfig{
{
SendResolved: ptr.To(true),
ChatID: 125,
ChatID: -1123123123125,
BotToken: &corev1.SecretKeySelector{
LocalObjectReference: corev1.LocalObjectReference{
Name: "tg-secret",
Expand Down Expand Up @@ -975,7 +975,7 @@ receivers:
telegram_configs:
- bot_token: some-token
send_resolved: true
chat_id: 125
chat_id: -1123123123125
message: some-templated message
templates: []
`,
Expand Down
Loading