OrderCommentDialog: comment modifier ordering, keyboard redesign, and related cleanups#361
Merged
No0ne558 merged 9 commits intoViewTouch:masterfrom Apr 8, 2026
Merged
Conversation
…ge loader; add safe_math helper and unit tests
… commit license_hash changes
Replaced manual malloc/free with std::vector/RAII in multiple modules; added Linux GetInterfaceInfo and safer GetMacAddress handling; added vt::BufferPool and integrated into vtcore; fixed mismatched free/delete and wrapped backtrace_symbols with RAII; updated changelog.
- Apply C++23 modernization and related cleanups across the codebase (core, main, zone, term, src, tests and utilities). - Update top-level docs and metadata: CMakeLists, README.md, SECURITY.md. - Add CPP23 modernization documentation and helper tooling: docs/CPP23_MODERNIZATION*, scripts/modernize_cpp23.sh. - Introduce utility headers and helpers (e.g. object_pool, thread_pool, xft_color_cache) and example cpp23 utilities under src/utils. - Refactor and tidy term layering (`term/layer.cc` / `term/layer.hh`) and other modules to improve API clarity and modern C++ usage. Summary: 193 tracked files modified, 17 new files added (approx.). This commit groups a wide modernization sweep; follow-up commits can split or revert specific parts if necessary.
…e insertion order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR groups the last 9 commits which together:
Commits included (most recent first):
Summary of notable changes:
call_ordercontextually so comments append like normal modifiers.OrderCommentDialogkeyboard keys set toFONT_TIMES_48B.UpdateQuickButtons()for quick-phrase suggestions and logic to populate/refresh buttons.