Skip to content

fix: ExpressionChangedAfterItHasBeenCheckedError #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: ExpressionChangedAfterItHasBeenCheckedError #182

merged 1 commit into from
Sep 25, 2023

Conversation

@mtlealr
Copy link
Contributor

@mtlealr mtlealr commented Aug 16, 2023 •
edited by OlivierAlbertini
Loading

close #93

@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Sep 22, 2023
@OlivierAlbertini OlivierAlbertini self-requested a review September 22, 2023 13:07
OlivierAlbertini
OlivierAlbertini reviewed Sep 22, 2023
View reviewed changes
@mtlealr mtlealr force-pushed the bugfix/issue-93-expression-changed-error branch from baa6843 to 60189e3 Compare September 22, 2023 19:45
OlivierAlbertini
OlivierAlbertini reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the releasing.md extra file and we are good to go, if you can squash in order to make 1 commit instead of 3, it would be perfect.

EDIT: also you need to rebase with the base branch (it seems to be out of date)

Thanks

@mtlealr
fix: ExpressionChangedAfterItHasBeenCheckedError
6b33b81 
Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>

fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
@mtlealr mtlealr force-pushed the bugfix/issue-93-expression-changed-error branch from 60189e3 to 6b33b81 Compare September 25, 2023 13:24
@mtlealr
Copy link
Contributor Author

mtlealr commented Sep 25, 2023

rebase and squash done

@OlivierAlbertini OlivierAlbertini merged commit a592729 into VilledeMontreal:master Sep 25, 2023
MaudeLaflamme pushed a commit to MaudeLaflamme/angular-ui that referenced this pull request Nov 14, 2023
@mtlealr @MaudeLaflamme
fix: ExpressionChangedAfterItHasBeenCheckedError (VilledeMontreal#182)
74b015f 
fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
(cherry picked from commit a592729)
Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
MaudeLaflamme added a commit that referenced this pull request Nov 14, 2023
@MaudeLaflamme @mtlealr
fix: ExpressionChangedAfterItHasBeenCheckedError (#182) (#198)
d214f05 
fix: replace ngAfterViewInit by ngAfterContentInit


(cherry picked from commit a592729)

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
Co-authored-by: mtlealr <142228898+mtlealr@users.noreply.github.com>
MaudeLaflamme pushed a commit that referenced this pull request Jul 17, 2024
@mtlealr @MaudeLaflamme
fix: ExpressionChangedAfterItHasBeenCheckedError (#182)
e172110 
fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
MaudeLaflamme pushed a commit to MaudeLaflamme/angular-ui that referenced this pull request Jul 18, 2024
@mtlealr @MaudeLaflamme
fix: ExpressionChangedAfterItHasBeenCheckedError (VilledeMontreal#182)
76f2a9d 
fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
MaudeLaflamme pushed a commit to MaudeLaflamme/angular-ui that referenced this pull request Jul 18, 2024
@mtlealr @MaudeLaflamme
fix: ExpressionChangedAfterItHasBeenCheckedError (VilledeMontreal#182)
cc6842f 
fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
MaudeLaflamme added a commit that referenced this pull request Jul 18, 2024
@MaudeLaflamme @mtlealr
fix: ExpressionChangedAfterItHasBeenCheckedError (#182) (#212)
d63ff6e 
fix: replace ngAfterViewInit by ngAfterContentInit

Signed-off-by: uleoner <ericandre.leon-rodas@montreal.ca>
Signed-off-by: Maude Laflamme <maude.laflamme@montreal.ca>
Co-authored-by: mtlealr <142228898+mtlealr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@MaudeLaflamme MaudeLaflamme Awaiting requested review from MaudeLaflamme

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fixer l'erreur ExpressionChangedAfterChecked de la composante Bao-Button

2 participants

@mtlealr @OlivierAlbertini