Skip to content

fix: ExpressionChangedAfterItHasBeenCheckedError #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix: ExpressionChangedAfterItHasBeenCheckedError #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/angular-ui/src/lib/button/button.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* See LICENSE file in the project root for full license information.
*/
import {
AfterViewInit,
AfterContentInit,
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
Expand Down Expand Up @@ -45,7 +45,7 @@ const LOADING_SPINNER_CLASS = 'loading-spinner';
'[class.bao-button-full-width]': 'fullWidth === true'
}
})
export class BaoButtonComponent implements AfterViewInit {
export class BaoButtonComponent implements AfterContentInit {
/**
* The display type of the button
*/
Expand Down Expand Up @@ -94,7 +94,7 @@ export class BaoButtonComponent implements AfterViewInit {
return this.elementRef.nativeElement;
}

public ngAfterViewInit() {
public ngAfterContentInit() {
const childNodes = Array.from(this.nativeElement.childNodes);
const textIndex = childNodes.findIndex(c => c.nodeType === Node.TEXT_NODE);
this.noText = textIndex === -1;
Expand Down