feat: update angular to 17 #221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierAlbertini
added
enhancement
OlivierAlbertini
force-pushed
the
feature/angular17
branch
from
d3c9396 to
f211348
Compare
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
OlivierAlbertini
force-pushed
the
feature/angular17
branch
from
f211348 to
d41eb1b
Compare
OlivierAlbertini
commented
Sep 6, 2024
| node-version: 20 | ||
| - run: npm ci | ||
| - run: npm run lint | ||
| # - run: npm run lint |
Member
Author
There was a problem hiding this comment.
linting broken with new version. I will create an issue since I dont find a solution right now
Member
Author
|
are you ok to merge ? |
MaudeLaflamme
approved these changes
Oct 25, 2024
Collaborator
|
@OlivierAlbertini cette PR est-elle en attente de quelque chose afin d'être mergé ? J'ai approuvé il y a plusieurs mois |
Member
Author
Non pas vraiment, c'est plus le linting qui me causait soucis. |
This was referenced Jun 17, 2025
Member
Author
|
cette PR va être fermée vu que #248 se base sur cette PR et corrige le problème de lint. |
This was referenced Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linting broken and I don't find solution for now
created #222 (for keeping track)