Skip to content

DXMT: avoid initial data for depth/stencil textures #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moreaki wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

DXMT: avoid initial data for depth/stencil textures #764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/VBox/Devices/Graphics/DevVGA-SVGA3d-dx-dx11.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3241,9 +3241,14 @@ static int vmsvga3dBackSurfaceCreateResource(PVGASTATECC pThisCC, PVMSVGA3DSURFA
* On NVidia the host driver does not allow initial data for large textures with D3D11_BIND_DECODER flag.
*/
D3D11_SUBRESOURCE_DATA *paInitialData = NULL;
/* Depth/stencil resources are initialized by subsequent rendering commands
* such as clears. Do not upload the optional host-side backing buffer here:
* it may be stale after hardware realization and DXMT's Metal path validates
* the source bytes during texture creation.
*/
if ( pSurface->paMipmapLevels[0].pSurfaceData
&& pSurface->surfaceDesc.multisampleCount <= 1
&& (BindFlags & D3D11_BIND_DECODER) == 0
&& (BindFlags & (D3D11_BIND_DECODER | D3D11_BIND_DEPTH_STENCIL)) == 0
)
{
/* Can happen for a non GBO surface or if GBO texture was updated prior to creation of the hardware resource. */
Expand Down