Report failing format commands - #121
Merged
Merged
Conversation
A finding the fixer declined, or the confidence gate held back, stayed on the books even after a later round fixed it: it came back in the final IgnoredIssues and was re-sent to reviewers as still declined. Both loops now drop fixed titles from the carried set and the gate ledger. Also trims the repeated declines rationale down to one copy.
The three exit arms of the review loop each folded gate rejects by hand, with an ordering rule only a comment stated. Exits now build a LoopExit and call conclude, which owns the fold. The fixer-halt arm of both loops shares one helper, so fixLoop also announces the bail-out.
…urce The Option parameter hid three coordinated behaviours that pinning changes. The initial-review prompt also claimed every diff covered the whole stage, which is not true for a pinned one, so the framing sentence now comes from the diff source.
A format command that fails produced no signal at all: the exit code was discarded, so a typo or a missing tool stayed invisible for the whole run. Each failing command now emits a Step naming it and its exit code, and the bash -c call shared with the lint gate moved into one runShell helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A format command that fails is invisible:
formatWorkspacethrows away the exit code, so a typo or a missing tool produces no output for the whole run. The samebash -ccall is also written out twice, here and in the lint gate.Each failing command now emits a Step with its name and exit code, and both call sites use one
runShellhelper. Failures still never stop the loop.Stacks on the review/rl-3 PR.
Finding:
docs/research/2026-08-review/review-loop/04-format-failures-invisible.md